Coder Social home page Coder Social logo

Comments (16)

andrezimpel avatar andrezimpel commented on June 8, 2024 4

@jenkin yes this is know for version 1. Just finishing up V2 as of writing this comment. Gonna publish it right now. It should resolve the issue.

from gatsby-plugin-gdpr-cookies.

jenkin avatar jenkin commented on June 8, 2024 3

@andrezimpel I have the same problem of @ahmadkhalaf1 : ga and fb work very well (without true cookies they don't set cookies or fire tracking requests), but gtm ignores settings, sets its cookies and fires events.

I think the problem is in this fragment inside the official gtm code snippet: w[l].push({'gtm.start':new Date().getTime(),event:'gtm.js'});. This event is fired regardless the user choice.

Here you can find a fix proposal that works for me (only gtm active): https://github.com/Dataninja/gatsby-plugin-gdpr-cookies/tree/hotfix/issue-30.

from gatsby-plugin-gdpr-cookies.

panszczypior avatar panszczypior commented on June 8, 2024 2

@andrezimpel same happened to me, I mean it starts to track even the user hasn't clicked decline or accept consent. No matter which option is selected and by saying that I mean setting the value of the cookie to false or true user is still tracked. On the opposite site to the OP I'm using google-analytics.

EDIT: It's working ! Turned out I didn't delete the other one plugin for GA.

from gatsby-plugin-gdpr-cookies.

jenkin avatar jenkin commented on June 8, 2024 2

@andrezimpel finally I implemented v2 and now all works fine, thanks!

from gatsby-plugin-gdpr-cookies.

andrezimpel avatar andrezimpel commented on June 8, 2024 1

@jenkin got you. Thanks for the support. I am having a look at this right now. I had actually the same issue with GA4 which I was finally able to solve.

from gatsby-plugin-gdpr-cookies.

andrezimpel avatar andrezimpel commented on June 8, 2024 1

@jenkin Sorry, I missed your last comment. I am about to finish 2.0 which is a complete rewrite. Nothing is every sent do Google or Facebook before the cookie es set and the plugin is initialized. Would you mind testing 2.0 out?

from gatsby-plugin-gdpr-cookies.

andrezimpel avatar andrezimpel commented on June 8, 2024 1

@jenkin So this issue should be solved, right?

from gatsby-plugin-gdpr-cookies.

jenkin avatar jenkin commented on June 8, 2024 1

Yes!

from gatsby-plugin-gdpr-cookies.

andrezimpel avatar andrezimpel commented on June 8, 2024

Dear @ahmadkhalaf1

thank you for the feedback. So basically GTM is working without giving the consent, right? I gotta have a look at this.

from gatsby-plugin-gdpr-cookies.

ahmadkhalaf1 avatar ahmadkhalaf1 commented on June 8, 2024

from gatsby-plugin-gdpr-cookies.

andrezimpel avatar andrezimpel commented on June 8, 2024

from gatsby-plugin-gdpr-cookies.

ahmadkhalaf1 avatar ahmadkhalaf1 commented on June 8, 2024

I‘m actually not using the tag manager for my projects. Would you mind doing a short screensharing session so I can see what’s going on? I might overhaul the tag manager integration and use the react-gtm package.

Sent from my iPhone
On 2. Dec 2020, at 09:58, ahmadkhalaf1 @.> wrote:  Thanks for your reply:) so basically only gatsbyRouteChange event is working after consent, but beside this I have some other dataLayer events , click events , scrolling , all these are passed to GTM without consent . On Wed, Dec 2, 2020, 8:18 AM Andre Zimpel @.> wrote: > Dear @ahmadkhalaf1 https://github.com/ahmadkhalaf1 > > thank you for the feedback. So basically GTM is working without giving the > consent, right? I gotta have a look at this. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#30 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AEMXYIDK6CMGU4CXWKMPDGDSSXS5ZANCNFSM4UI6RNQQ > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

sorry for late reply ,
sure we can have a zoom meeting and i can show you what i mean , because i also discovered a new issue related to the cookie , the cookie is removed from the browser if we close the tab , this mean that every time user close the tab and browser and open it again he will see the consent popup which is annoying , i dont know if thats how it meant to be or i am doing something wrong .

please let me know when its suitable for you to have our short call , tomorrow is a proposal from my side :)

thanks

from gatsby-plugin-gdpr-cookies.

andrezimpel avatar andrezimpel commented on June 8, 2024

Hey @ahmadkhalaf1 sorry for getting back late. Could you send me an email to [email protected] so we can find a time for a call asap?

from gatsby-plugin-gdpr-cookies.

jenkin avatar jenkin commented on June 8, 2024

@andrezimpel have you any news?

from gatsby-plugin-gdpr-cookies.

andrezimpel avatar andrezimpel commented on June 8, 2024

@panszczypior do you only have the trigger for the plugin in Tag Manager as described in the ReadMe or do you include all events?

from gatsby-plugin-gdpr-cookies.

jenkin avatar jenkin commented on June 8, 2024

Sorry @andrezimpel but also the latest version doesn't seem to work (see screenshot, the cookie bar is open, there is no cookie from this plugin, but facebook and ga start to tracking without problems).

I have to wait for next v2? Have you take a look to my proposed fix?

My gatsby config.

{
  resolve: 'gatsby-plugin-gdpr-cookies',
  options: {
    googleTagManager: {
      cookieName: 'gdpr-consent',
      trackingId: process.env.GOOGLE_TAG_MANAGER || ''
    },
    environments: ['production']
  }
}

Screenshot_20210317_173407

from gatsby-plugin-gdpr-cookies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.