Coder Social home page Coder Social logo

Comments (6)

MaartenZonneveld avatar MaartenZonneveld commented on July 26, 2024

Oh by the way, the TimeScroller is also broken in the Demo Project when running it on iOS 8.1. So I'm pretty sure it's not my code that's causing a problem.

from timescroller.

MaartenZonneveld avatar MaartenZonneveld commented on July 26, 2024

I've added some simple NSLog's to the ACTimeScroller.m.

iOS 7.1 output:

scrollViewDidScroll
checkChanges
Found a cell in scrollViewDidScroll. Going to update it...
updateDisplayWithCell <PFTimelineCell: (...)>

iOS 8.1 output:

scrollViewDidScroll
checkChanges
Did not found a cell in scrollViewDidScroll! Going to fade away now...

The code with the logs:

- (void)updateDisplayWithCell:(UITableViewCell *)cell
{
    NSLog(@"updateDisplayWithCell %@", cell);
   (...)
}

- (void)scrollViewDidScroll
{
    NSLog(@"scrollViewDidScroll");

    if (!_tableView || !_scrollBar)
    {
        [self captureTableViewAndScrollBar];
    }

    [self checkChanges];

    if (!_scrollBar)
    {
        return;
    }

    CGRect selfFrame = self.frame;
    CGRect scrollBarFrame = _scrollBar.frame;

    self.frame = CGRectMake(CGRectGetWidth(selfFrame) * -1.0f,
                            (CGRectGetHeight(scrollBarFrame) / 2.0f) - (CGRectGetHeight(selfFrame) / 2.0f),
                            CGRectGetWidth(selfFrame),
                            CGRectGetHeight(_backgroundView.frame));

    CGPoint point = CGPointMake(CGRectGetMidX(self.frame), CGRectGetMidY(self.frame));
    point = [_scrollBar convertPoint:point toView:_tableView];

    UITableViewCell* cell=[_tableView cellForRowAtIndexPath:[_tableView indexPathForRowAtPoint:point]];
    if (cell) {
        NSLog(@"Found a cell in scrollViewDidScroll. Going to update it...");
        [self updateDisplayWithCell:cell];
        if (![self alpha])
        {
            [UIView animateWithDuration:0.2f delay:0.0f options:UIViewAnimationOptionCurveEaseOut animations:^{
                [self setAlpha:1.0f];
            } completion:nil];
        }
    }
    else
    {
        NSLog(@"Did not found a cell in scrollViewDidScroll! Going to fade away now...");
        if ([self alpha])
        {
            [UIView animateWithDuration:0.2f delay:0.0f options:UIViewAnimationOptionCurveEaseOut animations:^{
                [self setAlpha:0.0f];
            } completion:nil];
        }
    }
}

- (void)checkChanges
{
    NSLog(@"checkChanges");
    (...)
}

from timescroller.

whuu avatar whuu commented on July 26, 2024

This could be fixed easily, just add:

  || imageView.frame.size.width == 2.5f

to if statement in captureTableViewAndScrollBar method in ACTimeScroller class

The line should look this way:

  if (imageView.frame.size.width == 7.0f || imageView.frame.size.width == 5.0f || imageView.frame.size.width == 3.5f || imageView.frame.size.width == 2.5f)

from timescroller.

andrewroycarter avatar andrewroycarter commented on July 26, 2024

Hey guys!
I've had github notifications turned off for a good while (I'm subscribed to so many darn projects at work) so I've missed these issues coming up.

I'll go through this project and do some cleanup over the next few days. Thanks for the interest!

from timescroller.

williamko avatar williamko commented on July 26, 2024

TimeScroller works on all of the device simulators except the iPhone 6 plus. Let me know if there is a quick fix!

Thanks Andrew!

from timescroller.

 avatar commented on July 26, 2024

Any progress on this? I'm having the same issue as williamko.

from timescroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.