Missing Recommended Dep? about df-lnp-installer

[andrewd18]

Looks like the upstream maintainer made a pretty radical change this morning:

changeset: 578:4294379f597b
tag: tip
user: joshb
date: Thu Oct 03 17:39:35 2013 +0200
summary: v.20.6 ** updated the project to qt 5.1.1 **

If you can install Qt5 development libraries, that's probably what you're missing. The install script assumes Qt4 (because up until last night, that's what you needed) so Qt dependency detection is going to be broken until I can either install Qt5 reliably or force a DwarfTherapist version that uses Qt4.

[andrewd18]

If you wanted to try and tackle this yourself, you will also need to edit the df-lnp-installer.sh script.

You'll need to change this function:

find_qmake_qt4 () {
  for name in "qmake" "qmake-qt4"; do
    if [ -n "$(which $name)" ] && [ $($name -query QT_VERSION | cut -d . -f 1) -eq 4 ]; then
        echo $name
        break
    fi
  done
}

to look like this:

find_qmake_qt4 () {
  for name in "qmake" "qmake-qt5"; do
    if [ -n "$(which $name)" ] && [ $($name -query QT_VERSION | cut -d . -f 1) -eq 5 ]; then
        echo $name
        break
    fi
  done
}

[frioux]

I may look into it, but for now decided to just skip on that tool entirely.

[wesQ3]

Would it be ok to explicitly declare which revision of the Dwarf Therapist repo you want to build to prevent upstream changes from unexpectedly breaking installs in the future?

I just built fine on Ubuntu 12.04 LTS with this:

diff --git a/df-lnp-installer.sh b/df-lnp-installer.sh
index 172d999..c4d036d 100755
--- a/df-lnp-installer.sh
+++ b/df-lnp-installer.sh
@@ -402,6 +402,7 @@ download_dwarf_therapist () {
   # Check for and fix the issue I had in 0.2.0 where I used the wrong upstream URL.
   # Get the current upstream url. If the directory doesn't exist the var will contain "".
   local CURRENT_UPSTREAM_URL="$(hg paths --cwd $DWARF_THERAPIST_HG_DIR | grep default | cut -d" " -f3)"
+  local DT_REVISION="4ef8173a7a94"

   if [ "$CURRENT_UPSTREAM_URL" != "$SPLINTERMIND_REPO_URL" ]; then
    # Inform the user (assuming they're paying attention)
@@ -413,7 +414,7 @@ download_dwarf_therapist () {
    fi

    # Reclone.
-   hg clone "$SPLINTERMIND_REPO_URL" "$DWARF_THERAPIST_HG_DIR"
+   hg clone -r $DT_REVISION "$SPLINTERMIND_REPO_URL" "$DWARF_THERAPIST_HG_DIR"
   else
    # URL is good; just get the latest changes.
    hg update --cwd "$DWARF_THERAPIST_HG_DIR"

[andrewd18]

wesQ3, that's a great idea. Implemented in 0.3.1. Thank you. Since this should resolve the issue (I was able to recreate and resolve it on my box too), I'm going to close this and open a separate enhancement issue for Splintermind 20.6 and Qt5 support.