Comments (62)
Let's take this in phases like the following:
- Moving current component logic to custom hooks
- Improving current component logic, removing unnecessary redux logic in favor of standard use state or jotai - I'm thinking for things like search, weather, createTrip etc. not everything needs to move out of redux immediately.
from packrat.
- search input
initial work on search input is done. still need to fix state logic after phase 1, still going through store
I'll have to rebase the SearchInput performance PR on this.
Ps: i'm almost done with the feed's VirtualList performance fix with tamagui and tanstack
from packrat.
not yet
@shahzi113awan have merged it to the "andrew_testing" branch?
from packrat.
can you kindly provide the branch where that component was done? @shahzi113awan
let me push the code
from packrat.
can you kindly provide the branch where that component was done? @shahzi113awan
let me push the code
from packrat.
in progress : map weather
I went through the code and noticed that weather and map are necessary for creating trips so I think I can switch to another tasks, while you are working on them
from packrat.
in Progress :
chat
from packrat.
Working on several components:
- trip
- hero
- carousel
- itemtable
- destination
from packrat.
:Working on Pack
Fixing breaking of code and refactor
from packrat.
- search input
initial work on search input is done. still need to fix state logic after phase 1, still going through store
from packrat.
Added list of components to issue FYI, let's track what has been done and what is still pending
from packrat.
- search input
initial work on search input is done. still need to fix state logic after phase 1, still going through store
I'll have to rebase the SearchInput performance PR on this.
Ps: i'm almost done with the feed's VirtualList performance fix with tamagui and tanstack
yes that would be great to rebase that, thanks. most of your logic should move over to the hook smoothly, i think we just need to update the on change handler and useRef in component side now
from packrat.
Moved about screen and appearance screen logic into custom hooks. https://github.com/andrew-bierman/PackRat/pull/537/files
from packrat.
:Working on Dashboard
from packrat.
Moved dashboard screen logic into custom hooks. #540
from packrat.
:Working on User screen
from packrat.
Moved User screen logic into custom hooks. #541
from packrat.
Still working on this: #542. Moving items screen into custom hooks.
from packrat.
:Working on Settings screen
from packrat.
Moved Settings screen logic into custom hooks #545
from packrat.
:Working on Login screen
from packrat.
Moved Login screen logic into custom hooks #546
from packrat.
:Working on Register screen
from packrat.
in progress
components:
[pack_table,
Dropdown.tsx,
TripCard.tsx]
from packrat.
Moved Register screen logic into custom hooks #548
I rebased from #546
from packrat.
:Working on Navigation / Drawer screen
from packrat.
One thing I noticed as well, we have a couple primitive ui elements still in our /components folder, ie dropdown, modal, etc. that should probably be handled via @packrat/ui (packages/ui).
The goal is all our base ui components live in the package, and the components in /client are the more complete pieces to go along with the new logic hooks. Component = Primitive ui elements + logic from hooks, essentially.
from packrat.
Additionally, every file in /hooks or /components should be in their own folders ie /components/packs and hooks/packs. Just to make it more scalable going forward as we add more features.
from packrat.
Moved Navigation and Drawer screen logic into custom hooks #550
from packrat.
:Working on Trip screen
from packrat.
:wroking on feeds
from packrat.
working on "progress" component
from packrat.
working on ScoreContainer.tsx
from packrat.
@shahzi113awan I'm working on trip screen, I saw you are working on the Tripcard component, did you finish it?, or if you haven't started yet can I take it?
from packrat.
@shahzi113awan I'm working on trip screen, I saw you are working on the Tripcard component, did you finish it?, or if you haven't started yet can I take it?
it's done already
from packrat.
@taronaleksanian can you please mark checked the items which you have done , so we don't need to search through comments
from packrat.
@shahzi113awan have merged it to the "andrew_testing" branch?
from packrat.
@taronaleksanian can you please mark checked the items which you have done , so we don't need to search through comments
I do when I merge them to the "andrew_testing" branch
from packrat.
can you kindly provide the branch where that component was done? @shahzi113awan
from packrat.
in progress :
map
weather
from packrat.
in progress components:
modal
dialog
from packrat.
working on password-reset
from packrat.
need to review pull request for progress component #560
from packrat.
In progress:
- Avatar.tsx
- GearList.tsx
- ItemRow.tsx
from packrat.
Refactor modal / dialog component done #564
from packrat.
working on
custombutton
multistep
from packrat.
Refactor custom button done #567
from packrat.
Refactor multistep form done #568
from packrat.
:working on
Components
- footer
- Select
- card
Screen
- items
from packrat.
working on
skeleton
card
InputText
EditableText
loading-placeholder
ThreeDotsMenu
from packrat.
Refactor skeleton component done #582
from packrat.
refactor components:
- DuplicateIcon
- Item
- PaginationChooseLimit
from packrat.
refactor components done:
- DuplicateIcon
- Item
- PaginationChooseLimit
from packrat.
refactor components done
card
EditableText
loading-placeholder
ThreeDotsMenu
from packrat.
refactor InputText done
from packrat.
working on
logo
landing_page
from packrat.
refactor landing_page logo done
from packrat.
I've made progress on this issue. Here's what I've done so far: [Inside Screens -> Appearance Folder]
- Refactored the
AppearanceContainer
component to separate concerns into smaller components. - Created new components:
ThemeSwitch
,DemoCard
,NativeBaseBox
,PaperCard
, andKitchenSink
. - Updated the
useAppearance
hook to manage the theme state.
I'm currently working on trip components inside screens. I'll continue to update this issue as I make more progress.
Here's the commit with my changes: [commit 4ab6099]
from packrat.
Done Refactoring TripDetailsComponent From inside Trip Folder inside screens:
Here's the commit with my changes: [commit 7e35339]
Please review and if you have suggestions let me know.
from packrat.
moved auth logic from redux to tanstack-query
#649
from packrat.
working on
move search state from redux to tanstack-query
from packrat.
Done refactoring about page. Separated the Created a new component and imported into index.js and took out the style on page to different file and imported into index.js.
Also I noticed some error with my last commit and did some update as well.
So, for those working on this issue please review and update accordingly.
from packrat.
Related Issues (20)
- Phase 1: Initial Migration to Drizzle ORM
- Next Js Integration for web ✨
- Logout button is crashing native application
- Next.js Feature Implementation Tracking HOT 1
- @rnmapbox/maps native code not available. Make sure you have linked the library and rebuild your app HOT 1
- trip
- Roadmap to a Native Feel on Mobile Devices HOT 1
- Fix Broken UI throughout Native App: Ensure all UI components render correctly and are fully functional across different devices and screen sizes. HOT 6
- packDetails broken
- search page HOT 2
- virtual lists + refresh on scroll. also infinite queries would be nice here HOT 1
- pack table needs to be fixed (lets decrease number columns with zeego DropdownPopover) HOT 1
- Alerts that Reflect Standards: Ensure the use of the Alert component aligns with expected standards, with appropriate titles, messages, and button configurations. See tamagui Alert with native set to true.
- Pull to Refresh with RefreshControl: Adopt the pull-to-refresh pattern for lists or scrollable areas.
- Implement Context Menus for Feed Cards: Utilize context menus to offer additional options or actions on long press. Zeego also provides support for this.
- Trip details screen (viewing a single trip)
- Fix form validations
- Cannot update a component (`ToastProvider`) while rendering a different component (`Login`).
- Segmented Control for Toggling Views: Integrate segmented controls for switching between different views or filtering content. A custom implementation or third-party library may be required as Expo lacks a specific library.
- Large Titles with react-navigation: Incorporate large titles in stack navigators, especially for top-level views.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from packrat.