Parse Decimal number without thousands delimiter about parse-decimal-number

[AndreasPizsa]

Thank you for opening this issue, @kirbyjs !

You can use an "invalid" thousands delimiter to get the behavior you want:

parseDecimalNumber('1,234,123.12', [null, '.'])
// <- NaN

parseDecimalNumber('1234123.12', [null, '.'])
// <- 1234123.12

Does this solve your issue?

[kirbyjs]

@AndreasPizsa sorry I didn't completely clarify:

I am currently using cldr with this module. I tried to set group: undefined but it looks like you default to the inOpts.thousand option if inOpts.thousand and inOpts.group is falsey.

cldr doesn't have a thousand property so with the default options here, thousand is still set to ,.

So I could set thousand: undefined as well to get around the issue, but just wanted to check to see that that behavior is the expected behavior.

[AndreasPizsa]

Got it - that makes a lot of sense.

I'll look into it soon; meanwhile, if you want to submit a PR, please feel free to do so!

[AndreasPizsa]

Would this do what you're expecting, @kirbyjs ?

const cldr = require('cldr')
var parseDecimalNumber = require("parse-decimal-number")

const numberSymbols = cldr.extractNumberSymbols('en_US')
parseDecimalNumber("1234123.12", [null, numberSymbols.decimal])
// <- 1234123.12

parseDecimalNumber("1,234,123.12", [null, numberSymbols.decimal])
// <- NaN

https://runkit.com/andreaspizsa/runkit-npm-parse-decimal-number

[kirbyjs]

Yep, it works! I'm cool with that solution. Thanks a ton @AndreasPizsa!