Not support custom rules? about laravel-api-to-postman

[andreaselia]

Hi @sunxyw, thank you for reporting this issue.

I believe I've managed to reproduce this in #72, so will work on a fix when I get a little time. If you have any suggestions towards a fix, feel free to message over on the PR 😄

(cc: @tomirons)

[sunxyw]

Good, please take your time, this is not in a hurry.

[andreaselia]

This has now been resolved in the latest release. Thanks again for your help on the issue.

[andreaselia]

#72 stops this throwing an error, we still don't have support for custom rules at this moment in time though.

[sunxyw]

This error still presents even updated to the latest version v1.12.1.

[andreaselia]

Weird, I thought the test case would have caught this. I’ll take a look at this when I get back home in a few hours.

cc: @tomirons

[sunxyw]

I tried fixing it myself, maybe it wasn't the best way, but it did get rid of the error.

laravel-api-to-postman/src/Commands/ExportPostmanCommand.php

Lines 329 to 330 in 352cc1b

	if (is_array($rules)) {
	$this->validator = Validator::make([], [$attribute => implode('|', $rules)]);

if (is_array($rules)) {
    foreach ($rules as $i => $rule) {
        if (is_object($rule)) {
            unset($rules[$i]);
        }
    }
    $this->validator = Validator::make([], [$attribute => implode('|', $rules)]);

[andreaselia]

Hi @sunxyw,

I'll be taking a look at this today, I had a bit of a busy day yesterday so didn't get round to it.

Thanks for posting your solution. I'll need to be able to reproduce this through a unit test before I can submit a fix though.

Do you have any ideas how we could maybe reproduce it in a unit test?

[andreaselia]

Okay, I managed to reproduce it. It's when a rule class is within an array of rules.