Comments (3)
Thanks for the report @iAklis. After looking at this issue a bit and your PR, it seems as though you've ascertained that the network connections are being held open, resulting in an increase in resource usage.
The current model creates a new docker client per GetImageFromSource
calls.
I'm not sure adjusting the IdleTimeout
is necessarily a fix, but rather a fix for a specific case with specific timing/etc.. A couple of alternative fixes we discussed:
- Allow the caller to manage the connection and pass it in to a function similar to
GetImageFromSource
- Ensure all client connections are closed when calling
img.Cleanup()
I think these solutions are somewhat mutually exclusive, do you have any thoughts here?
We'll bring this up again next week with the team but in the meantime please feel free to comment if you're able.
from stereoscope.
@iAklis I agree with @kzantow here. What isn't obvious about the timeout approach is that if someone is using the API and is delaying using of the provider after it's creation (say more than 10 seconds) then there should be non-obvious failures when attempting to use the object.
from stereoscope.
@kzantow I'm sorry for my late reply. I agree with you that setting IdleTimeout
is not an efficient and elegant way.
And it's redundant here.
In my mind, per GetImageFromSource calls own its daemon client and don't share it with others.
After looking at @wagoodman 's patch, I think his solution is better.
Thank @wagoodman and @kzantow .
from stereoscope.
Related Issues (20)
- It should be possible to specify image platform when pulling from the registry
- Wrong source when ":" character in path
- Cleanup temp directories across image providers HOT 5
- SquashFS Iteration Fails when FIFO Present
- SquashFS iteration fails with "unexpected EOF" HOT 1
- Unable to read image using Docker daemon provider when architecture has variant
- Stereoscope pulls different images when using ``docker:`` vs ``registry:`` from multi-platform images
- Symlink not being recognized HOT 4
- Embed fs.FileInfo in Metadata Struct?
- Support for image indexes with multiple manifests HOT 4
- Odd error message when docker.socket in home dir is used
- Stereoscope cannot inspect images in Docker Desktop HOT 15
- Data Race in Image.Read
- Platform selection in docker client has unnecessary error HOT 2
- NewTarIndex race condition when run in a goroutine HOT 6
- Add support for containers-storage backend for container images
- Cycle during symlink resolution prevents syft/grype scans from enumerating vulnerabilities
- Add release process
- Concurrently analyzing containers can lead to race condition causing error HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stereoscope.