Coder Social home page Coder Social logo

Comments (3)

kzantow avatar kzantow commented on May 28, 2024

Thanks for the report @iAklis. After looking at this issue a bit and your PR, it seems as though you've ascertained that the network connections are being held open, resulting in an increase in resource usage.

The current model creates a new docker client per GetImageFromSource calls.

I'm not sure adjusting the IdleTimeout is necessarily a fix, but rather a fix for a specific case with specific timing/etc.. A couple of alternative fixes we discussed:

  • Allow the caller to manage the connection and pass it in to a function similar to GetImageFromSource
  • Ensure all client connections are closed when calling img.Cleanup()

I think these solutions are somewhat mutually exclusive, do you have any thoughts here?

We'll bring this up again next week with the team but in the meantime please feel free to comment if you're able.

from stereoscope.

wagoodman avatar wagoodman commented on May 28, 2024

@iAklis I agree with @kzantow here. What isn't obvious about the timeout approach is that if someone is using the API and is delaying using of the provider after it's creation (say more than 10 seconds) then there should be non-obvious failures when attempting to use the object.

from stereoscope.

iAklis avatar iAklis commented on May 28, 2024

@kzantow I'm sorry for my late reply. I agree with you that setting IdleTimeout is not an efficient and elegant way.
And it's redundant here.
In my mind, per GetImageFromSource calls own its daemon client and don't share it with others.

After looking at @wagoodman 's patch, I think his solution is better.

Thank @wagoodman and @kzantow .

from stereoscope.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.