Comments (7)
Yes, but the current check only considers the configuration of the markdown plugin. This example is using Starlight, and it seems that handles its own markdown config internally. I can look into improving detection to show the warning.
from analog.
This is due to a known incompatibility between Astro's Remark Shiki plugin and Zone.js. Unless another solution or workaround comes along, we'd have to wait for zoneless.
from analog.
Thanks @rlmestre. I thought the Astro plugin automatically warned about this?
from analog.
Hi @rlmestre @brandonroberts,
Thank you for taking care of my issue.
I am looking forward to using Angular with Astro by analog. 😁
from analog.
I opened an issue in the repo for the dependency that's causing the issue. Unfortunately, I think it's a long shot, but we'll see.
The good news is we finally have a root cause and it doesn't seem to be as big of a deal as native async/await conflicts with Zone. The bad news is we'll continue to run into packages that use async plugins or transformers causing these issues. In this case it's Starlight's expressive code.
You can disable expressive code by passing false
to the property in starlight's astro.config
:
import { defineConfig } from 'astro/config';
import starlight from '@astrojs/starlight';
import angular from '@analogjs/astro-angular';
export default defineConfig({
integrations: [starlight({
expressiveCode: false,
...
})],
});
@brandonroberts do we want to add a warning and/or override for this particular one as well?
from analog.
My issue/PR were accepted, so the issue has been fixed upstream! To fix it "the right way", we need to wait for the dependency to be updated in unified
and then Astro. If you want to try it now, you can override the package:
"pnpm": {
"overrides": {
"trough": "2.2.0"
}
}
from analog.
Awesome, thanks @rlmestre!
from analog.
Related Issues (20)
- Docs: add guide on using environment variables HOT 2
- How can I do api request? HOT 3
- Docs: explain on how to name nested API routes HOT 3
- Update nitropack version HOT 5
- Can't add vitest to project HOT 1
- Docs: Add guide on integrating Storybook with Angular and Vite using the Vite Plugin for Angular
- cloudflare wrangler not working with the analog-app example HOT 2
- 'Post build' Hook HOT 2
- npm create analog@latest: npm install fails HOT 2
- Issue when building @angular/fire in Nx HOT 7
- Cannot access assets under the assets folder HOT 1
- [@analogjs/vitest-angular] latest beta has incorrect dependency version requirement on @angular-devkit/architect
- Can't test with `it/describe.each` and `fakeAsync`
- Cant stop ng serve HOT 4
- nx migrate not working HOT 2
- Add error message when `xx.page.ts` does not have a default export
- Issue with Route Guards from @angular/fire HOT 1
- Bug: Using Shiki highlighter produces too many lazy chunks by default HOT 1
- Importing `injectContent` in root causes the dev server to hang? HOT 2
- Documentation for `@analogjs/vitest-angular` is using imports from `@analogjs/vite-plugin-angular` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from analog.