Error when admissionid is negative in get_fluidbalance amsterdamumcdb/fluidbalance.py about amsterdamumcdb

[patrickthoral]

I don't understand why admissionid could be a negative value, but you are definitely correct that the code will fail on negative values for from_date or to_date, though for fluid balance there should not be any data before the first ICU admission.

However, I did not realize str.isnumeric() required all characters to be numeric to return True:

From https://docs.python.org/3/library/stdtypes.html?highlight=isnumeric#str.isnumeric:

str.isnumeric()
Return True if all characters in the string are numeric characters, and there is at least one character, False otherwise. Numeric characters include digit characters, and all characters that have the Unicode numeric value property, e.g. U+2155, VULGAR FRACTION ONE FIFTH. Formally, numeric characters are those with the property value Numeric_Type=Digit, > Numeric_Type=Decimal or Numeric_Type=Numeric.

I will follow your suggestion to convert the type and handle the exception.

[joaocolaco]

Yes you are right. admissionid should not be negative number, I had my wires crossed. I wanted to talk about the dates.

[patrickthoral]

Fixed by the latest commit.