Channel can provoke connection error in publish/sendToQueue about amqplib

[squaremo]

There's two problems here. The superficial problem is that sendMessage doesn't check its arguments. The deep problem is that a sendMessage can fail halfway through, effectively leaving the whole connection in an unrecoverable state.

Certainly the first is easy to fix, at least in the case of the buffer supplied as content (not so much for, say, a deeply nested table supplied in 'headers').

The second would need the message send to be atomic, and that isn't really practical. However, at least encoding both the method and properties before writing them would make it atomic w.r.t., encoding.

[michaelklishin]

I believe that's what Java client does and what I've been asked to make Bunny do.

[squaremo]

Fixed in ed3f93d, by changing the connection API around a bit so that one can send a publish method and message headers in one method call. (And it now checks that content is a buffer)