Comments (15)
Hi @jsw
Please set the customDomain.stage
to the $default
or just remove the stage option and the plugin will set it to $default
More info is here: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-stages.html
from serverless-domain-manager.
I second this issue, and I can confirm that setting customDomain.stage
to $default
helps overcome this error.
However it'll only deploy to our stg environment, it fails to deploy afterwards to prod.
This is the error received on an attempt to deploy to prod (using $default
):
Error:
UPDATE_ROLLBACK_IN_PROGRESS: loans-v3-*** (AWS::CloudFormation::Stack)
Export with name sls-loans-v3-default-DistributionDomainNameHttp is already exported by stack loans-v3-staging
from serverless-domain-manager.
I second this issue, and I can confirm that setting
customDomain.stage
to$default
helps overcome this error.However it'll only deploy to our stg environment, it fails to deploy afterwards to prod. This is the error received on an attempt to deploy to prod (using
$default
):Error: UPDATE_ROLLBACK_IN_PROGRESS: loans-v3-*** (AWS::CloudFormation::Stack) Export with name sls-loans-v3-default-DistributionDomainNameHttp is already exported by stack loans-v3-staging
Thank you for highlighting it!
We are going to release a fix for it today.
from serverless-domain-manager.
I am seeing this error - was it supposed to be resolved in the latest update? I just updated to v7.1.1 today and started seeing this issue. Will try the fix above but curious if there is something else I need to do. Thanks!
Upgrading to v7.1.1
and setting the customDomain.stage
to $default
works!
Here's an example snippet:
customDomain:
domainName: ${env:DOMAIN, ''}
stage: $default
basePath: v3/loans
apiType: http
endpointType: regional
from serverless-domain-manager.
Hi @zoli-kasa
It was a bit tricky release as it was a bug fix for the #578.
This issue is related only to the HTTP API type and not to the REST or Websocket.
Also, this is an AWS behavior to not allow to create a custom stage without $default
for the HTTP API type.
One more thing is that the plugin will set $default
stage for you in case not specified in the config.
But in general, the concern is right and we will take it into account in our further releases.
from serverless-domain-manager.
Hi @jsw
Is the issue solved for you now? Are we good to close the issue?
I have confirmed that removing custom.customDomain.stage
fixes the issue. I have tested multiple stages. Thanks for the solution.
from serverless-domain-manager.
Thank you for the response @belferink1996! Our issue ended up being another result of updating with the aws sdk. I can confirm that the $default stage with version 7.1.1 does work.
Thanks!
from serverless-domain-manager.
maybe this should've been a major change, if the API is not compatible with the previous one?
from serverless-domain-manager.
maybe you could write a detailed change about this in the release log, to help other users with the same issue during upgrade?
from serverless-domain-manager.
Hi @rddimon
Thanks for the response. Can you elaborate at bit? You want me to change customDomain.stage
from ${self:custom.stage}
to ${default}
? Or maybe dev
, which I guess is the "default" stage, which is the value of provider.stage
.
Did something change between 7.0.4 and 7.1.0 that requires me to update serverless.xml? I explicitly set the stage in each of my environments, e.g. sls deploy --stage dev
and this works in 7.0.4 but not 7.1.0. Is that expected?
from serverless-domain-manager.
I'm getting a similar issue related to v7.1.0 where I can't deploy to prod after deploying to staging with the following error:
Export with name sls-back-end-default-HostedZoneIdHttp is already exported by stack back-end-staging
from serverless-domain-manager.
Hi @rddimon
Thanks for the response. Can you elaborate at bit? You want me to change
customDomain.stage
from${self:custom.stage}
to${default}
? Or maybedev
, which I guess is the "default" stage, which is the value ofprovider.stage
.Did something change between 7.0.4 and 7.1.0 that requires me to update serverless.xml? I explicitly set the stage in each of my environments, e.g.
sls deploy --stage dev
and this works in 7.0.4 but not 7.1.0. Is that expected?
In 7.1.0 we released a fix for the issue #578
the custom.customDomain.stage value is being ignored
It looks like, from the AWS documentation, that for the HTTP
APIs we need to have the $default
stage created before creating any other custom stages
To simply fix your issue you will need just to remove ustomDomain.stage
option from the HTTP
configurations
from serverless-domain-manager.
I am seeing this error - was it supposed to be resolved in the latest update? I just updated to v7.1.1 today and started seeing this issue. Will try the fix above but curious if there is something else I need to do.
Thanks!
from serverless-domain-manager.
Hi @jsw
Is the issue solved for you now? Are we good to close the issue?
from serverless-domain-manager.
maybe you could write a detailed change about this in the release log, to help other users with the same issue during upgrade?
It might be harder to predict issues
But yeah good suggestion we will try to add known solutions next time
from serverless-domain-manager.
Related Issues (20)
- Stop using ^ in your dependencies, it makes everyone sad HOT 2
- unable to set multiple segments in base path HOT 2
- deploymentRole not being assumed HOT 1
- Failed to find a stack (v7.0.4) HOT 6
- IPv6 Support | API Gateway HOT 1
- Update aws-sdk deps
- Serverless Domain Manager: Plugin configuration is missing. HOT 2
- Failed to find a stack XXX HOT 8
- Section content for "Serverless Domain Manager" was already set HOT 1
- Error: Failed to find a stack xxx HOT 1
- Incorrect hosted zone chosen when attempting to create a custom domain name
- Log is undefined when plugin is added programatically HOT 1
- Resolved credential object is not valid HOT 7
- Hosted Zone name matching broken in v7.3.1 HOT 2
- failed to find a stack error HOT 2
- Custom domain target is not the same as the endpoints url HOT 1
- Unable to update base path mapping HOT 8
- Unable to update base path mapping HOT 1
- proxy-agent-6.3.1.tgz: 1 vulnerabilities (highest severity is: 9.8) - autoclosed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serverless-domain-manager.