Comments (5)
I just replaced the pool implementation in v0.3.0, but this is still an issue in the new implementation. I'll look into adding a timer that closes connections after a period of time. Same in the postgres library.
from mysql.
Y'all probably already know this but sharing for general info and posterity here ...
The approach that's works well for this kind of thing in aerys is having each connection carry its own "state" object with a lastUsedAt
timestamp (or equivalent). Then there's a single timer watcher for the pool that triggers once per second to iterate over all open connections that aren't awaiting a response from the other party to check if (now - lastUsedAt) > configurableClientLevelIdlenessTimeout
...
In general it's important to avoid individual per-connection timers because: overhead.
from mysql.
@rdlowrey Yeah, that's the approach I was going to take. The pool implementation has a queue of idle connections where the most recently used goes at the end, so I should be able to just iterate from the front, removing connections as necessary. A busy pool would only need to examine a single connection.
from mysql.
@rdlowrey it's an optimization, it's not actually important. A userland MySQL client has other bottlenecks.
from mysql.
That's done, right?
from mysql.
Related Issues (20)
- Implement Support for Protocol::AuthSwitchRequest
- Can we use Named parameters in SQL queries with amphp\mysql package? HOT 1
- Can we have lastInsertId returned in a different method when UUID is used as Primary Key? HOT 4
- Connection closed unexpectedly HOT 4
- Values not saved when named parameters are used in SQL insert queries with amphp\mysql package HOT 3
- about wrapping CommandResult HOT 1
- multi query with prepared statement HOT 5
- Different query result under transaction
- v3 not work HOT 3
- Connection open + one select + close takes about 30 ms HOT 5
- Prepared Statements don't work with DATETIME columns HOT 2
- Reaching connection limit results in protocol version exception HOT 1
- Incorrect handling of fractional seconds in Datetime, and Timestamp columns HOT 3
- Connection closed unexpectedly HOT 2
- Cannot install HOT 5
- Unable to connect to AWS Aurora MySQL 3.04.0 (MySQL 8.0.28) over TLS HOT 5
- Connection closed unexpectedly HOT 4
- Closing database connection while query is still pending HOT 2
- Infinite recursion when iterating HOT 5
- v2: is it possible to set a limit on the max number of parallel connections? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mysql.