Coder Social home page Coder Social logo

Comments (5)

kelunik avatar kelunik commented on June 9, 2024 1

I've just released v0.9.10 with the fix.

from dns.

kelunik avatar kelunik commented on June 9, 2024

This is a valid concern, as a DNS resolver might be used standalone without relying on the global instance.

from dns.

brstgt avatar brstgt commented on June 9, 2024

Also it is not possible to correctly clean loop/resolver instances e.g. when it is replaced with another instance which happens massively in tests.

from dns.

brstgt avatar brstgt commented on June 9, 2024

Tested and works for manual cleanup:

    public function shutdown() {
        if ($this->gcWatcher !== null) {
            Loop::cancel($this->gcWatcher);
            $this->gcWatcher = null;
        }
    }

    public function __destruct() {
        $this->shutdown();
    }

from dns.

kelunik avatar kelunik commented on June 9, 2024

@brstgt Cyclic references shouldn't matter in tests and should be cleaned up correctly during the loop switch.

from dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.