Latest docker image error about ampache-docker

[troycarpenter]

I am not getting this on my stand-alone test machine which is up to date with the develop branch.

It looks like there's something there about proxy headers, so that might explain why I'm seeing it on the production server and not the development server.

[troycarpenter]

So the quick fix was to comment out lines 142 through 145 in src/Module/System/Core.php. Since I am using a proxy, I just simply returned the value for HTTP_X_FORWARDED_FOR variable.

The problem is this statement:
filter_has_var($_SERVER['HTTP_X_FORWARDED_FOR'], FILTER_VALIDATE_IP)

[troycarpenter]

I think this is a problem in the source, not with the docker image itself.

[shikasta-net]

I can confirm this issue. I'll try your fix. It's probably an unfortunate combination of PHP8 update and the source, and proxies.

[shikasta-net]

Yup, unborked by doing the following:
replace filter_has_var($_SERVER['HTTP_X_FORWARDED_FOR'], FILTER_VALIDATE_IP) with filter_var($_SERVER['HTTP_X_FORWARDED_FOR'], FILTER_VALIDATE_IP).
The function filter_has_var is the wrong function and should probably be filter_var, but the && means this bug only occurs if the header is set; i.e., using a proxy.

[troycarpenter]

Due to other problems I'm having with this image (LDAP issues with some users), I had to restore the previous image. I'm not able to try the filter_var change to see if that's what the change should be.

[troycarpenter]

I see you made the fix. I'm trusting the function change is the root. Focusing on the LDAP problem that has crept up. Seems one of my LDAP users (me, specifically) stopped working about three DOCKER images ago when trying to log in via the Subsonic API. So far I've seen other users log in via their mobile apps, so it may be that my password has newly blocked characters.