pbs.convert raise an error about sh

[ifduyue]

convert is a command tool ImageMagick provides

[amoffat]

Hi Du, unfortunately this is a problem with how pbs and shlex split up arguments. There will be a workaround in v1.0 if I can find it, but in the meantime, you can do this:

pbs.convert("-crop", "+0+67", "some.jpg", "crop.jpg")

[amoffat]

Just an update, there will be no workaround in v1.0. It seems that the best way to handle passing arguments to commands is to split them up with the understanding that 1 argument to the pbs command should correspond to 1 argument being passed to the subprocess. I've updated the readme to reflect this.

So in other words, this:

pbs.convert("-crop +0+67", "some.jpg", "crop.jpg")

should always be this:

pbs.convert("-crop", "+0+67", "some.jpg", "crop.jpg")

Because "-crop" and "+0+67" are separate arguments to the "convert" binary, and using shlex.split() to split up arguments automagically is broken and full of problems.

[ifduyue]

pbs.convert("-crop", "+0+67", "some.jpg", "crop.jpg") works.

thanks, amoffat.