Coder Social home page Coder Social logo

Comments (7)

ammarahm-ed avatar ammarahm-ed commented on May 18, 2024 1

I will add the defs! Thanks for reporting

from react-native-actions-sheet.

ammarahm-ed avatar ammarahm-ed commented on May 18, 2024 1

fixed in v0.4.4
There is also a new prop added that you can use:

<ActionSheet
onPositionChanged={(onReachedTop)=>{}}
/>

from react-native-actions-sheet.

ammarahm-ed avatar ammarahm-ed commented on May 18, 2024 1

@ammarahm-ed why onPositionChanged is a mandatory prop? I think it should be optional

Yeah, I think I forgot to add "?" in type defs

from react-native-actions-sheet.

naderalfakesh avatar naderalfakesh commented on May 18, 2024

Currently I am using until we get the defs in the new release:
Thanks in advanced

useEffect(() => {
    DeviceEventEmitter.addListener('hasReachedTop', callback);
    return () => {
      DeviceEventEmitter.removeListener('hasReachedTop', callback);
    };
  }, []);

from react-native-actions-sheet.

efstathiosntonas avatar efstathiosntonas commented on May 18, 2024

@ammarahm-ed why onPositionChanged is a mandatory prop? I think it should be optional

from react-native-actions-sheet.

ammarahm-ed avatar ammarahm-ed commented on May 18, 2024

@ammarahm-ed why onPositionChanged is a mandatory prop? I think it should be optional

Published new version with the fix.

from react-native-actions-sheet.

efstathiosntonas avatar efstathiosntonas commented on May 18, 2024

Thanks for the quick fix!! Keep up the great work!

from react-native-actions-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.