XSS vector in Question Page Breadcrump Generator about q2a-breadcrumbs

[amiyasahu]

I will fix this issue as soon as I can.

[svivian]

FYI you can use the qa_html function for this.

[amiyasahu]

Yes it fixes the search function as well.

[thierryzoller]

https://github.com/amiyasahu/q2a-breadcrumbs/blob/master/inc/Ami_BreadCrumbOptions.php

Note: This issue originally was discovered by Steve Ehleringer. (Credit)

[thierryzoller]

The best place to patch would be to sanitze at Ami_BreadcrumbElement.php, see here

        public function get()
        {
            $breadcrumb_structure = qa_opt( q2a_breadcrumbs_admin::NO_LINK_AT_LAST_ELEM ) && $this->is_last_elem() ?
                $this->breadcrumb_structure_nolink
                : $this->breadcrumb_structure;
		    
			$test = htmlspecialchars($this->text);
            
			return strtr( $breadcrumb_structure, array(
                '{{class}}' => $this->class,
                '{{url}}'   => $this->url,
                '{{text}}'  => $test,
            ) );
        }

[amiyasahu]

@thierryzoller , I have fixed this in the dev branch. Let me know if you are still facing the issue.

[thierryzoller]

The ‘search’ function has the same issue - would advise to ensure all output is verified.

…

Am 24.06.2019 um 14:11 schrieb Amiya Sahu ***@***.***>: @thierryzoller , I have fixed this in the dev branch. Let me know if you are still facing the issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.