Coder Social home page Coder Social logo

Comments (4)

amir-zeldes avatar amir-zeldes commented on August 29, 2024

Thanks for reporting! Number 2 is not the construction "down there" IMO, so we shouldn't touch the following in any case:

  • "hung it up/RP here/RB", i.e. hang+up phrasal verb, and I see "up" is actually tagged RP in the corpus

I think there are contexts in which "down" can be an adverb:

  • I pointed down/RB (=downward/RB)
  • I pointed there/thataway/... - RB

I think for "down there" the reason to tag down as a preposition in PTB is by analogy to "in there", but generally I think this down is more like an adverb meaning "below, at the bottom" (in this reading down there would be like 'there at the bottom'). Despite my personal intuition, ordinarily I'd say we should accept IN RB to match PTB, but... looking in EWT I see that it's consistently RB RB:

http://match.grew.fr/[email protected]&custom=5f75152d74ff3&eud=yes

And what's more, the deprel is advmod into 'down', which the UD validator would reject if upos!=ADV. Because we are much more likely to want to concatenate GUM with EWT, maybe it's worth matching it rather than PTB??

from gum.

lgessler avatar lgessler commented on August 29, 2024

That makes sense, yeah. Personally I've grown really weary of the IN/RB/RP distinction when it comes to words like down, up, over, under, etc. and in many cases I feel like the choice of which tag to use can be nothing else but arbitrary. But I suppose there's nothing to be done but to choose one and stick to it as long as we're using PTB tags.

from gum.

amir-zeldes avatar amir-zeldes commented on August 29, 2024

Yes, I think it's basically construction by construction. To some extent, correcting/adjudicating with NLP output is better because it can be more consistent: adnominal out + of -> IN IN; but if it's a verb+RP combination -> RP IN (e.g. run out of coffee)

At some point it becomes a bit of a shopping list, you just want to make sure it's the same shopping list for GUM, EWT, ... Could really use some automatic consolidation suggestions, probably.

from gum.

amir-zeldes avatar amir-zeldes commented on August 29, 2024

Fixed in 6.2.0

from gum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.