Coder Social home page Coder Social logo

Accept JSON type about sqladmin HOT 4 CLOSED

aminalaee avatar aminalaee commented on June 23, 2024
Accept JSON type

from sqladmin.

Comments (4)

aminalaee avatar aminalaee commented on June 23, 2024

Hey @rcourivaud ,

Thank you for reporting this. I think this needs two steps:

  • First we need to add PostgreSQL tests to the Github actions so that we have coverage: #30
  • Then we can add the JSON converter which should not be much complicated (at least for the backend side).

Feel free to do any PRs for these.

from sqladmin.

lovetoburnswhen avatar lovetoburnswhen commented on June 23, 2024

What if we used sqlalchemy-utlis to automatically serialize the data based on the engine's dialect? https://sqlalchemy-utils.readthedocs.io/en/latest/data_types.html#module-sqlalchemy_utils.types.json

This could also be used for array types https://sqlalchemy-utils.readthedocs.io/en/latest/data_types.html#module-sqlalchemy_utils.types.scalar_list

from sqladmin.

aminalaee avatar aminalaee commented on June 23, 2024

Yeah at some point we should consider sqlalchemy-utils and geo-alchemy and other libraries. It's the same process as supporting SQLModel, basically needs to define WTForm converters for those fields.
But we need the sqlalchemy.dialects.postgresql.json.JSON support anyway as it can be used without the sqlalchemy-utils library.

So I think for this issue we can focus on JSON type in PostgreSQL dialect and in another issue track sqlalchemy-utils. What do you think?

from sqladmin.

aminalaee avatar aminalaee commented on June 23, 2024

So looks like the JSON column in SQLAlchemy would cover all JSON compatible columns in databases supporting JSON like PostgreSQL and the ones not supporting like SQLite.
This should be good for now.

from sqladmin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.