Coder Social home page Coder Social logo

Comments (7)

BradLugo avatar BradLugo commented on June 9, 2024

I'm trying to decide a good way to do this. The best solution I've come up with so far is to delete all of the index.ron files in templates/<version-number>/<template-name> and create index.ron or templates.ron either to templates or the root of the project with an object structure something like this:

Templates(
    <version-number>: {
        <template-name>: [
            "<file-name>",
            "<file-name>",
        ],
        <template-name>: [
            "<file-name>",
            "<file-name>",
        ]
    },
    <version-number>: {
        <template-name>: [
            "<file-name>",
            "<file-name>",
        ],
        <template-name>: [
            "<file-name>",
            "<file-name>",
        ]
    }
)

Thoughts?

from tools.

torkleyy avatar torkleyy commented on June 9, 2024

Why do you need to put it all into on RON file? I'd just leave it in the individual files, but change the contents to a struct.

from tools.

BradLugo avatar BradLugo commented on June 9, 2024

That's definitely on the table. My thought was that having the versions and template types in a single RON file would allow us to compile and know exactly what files are included. I'm not a huge fan of relying on the filesystem for data consistency, i.e., the compilation would fail if we configured a version in the RON file and the compiler couldn't find it vs. the compiler not seeing it the version in the filesystem and not including it but compiling successfully anyway.

At a certain point, I'm over-engineering this, so I'm ok with implementing it the way you suggested.

from tools.

torkleyy avatar torkleyy commented on June 9, 2024

I see. Well, I think both solutions are okay. I'm pretty sure it's fine to trust the file system though ^^

from tools.

BradLugo avatar BradLugo commented on June 9, 2024

Ultimately, y'all are the maintainers, so I'll implement what y'all think is best. Left to my own devices though, I'm going to choose the single file solution unless you tell me otherwise.

from tools.

torkleyy avatar torkleyy commented on June 9, 2024

Sounds good 👍

from tools.

CleanCut avatar CleanCut commented on June 9, 2024

👋 I'm closing all PRs and Issues since amethyst_tools is being end-of-life'd. Please see this forum post for a place to respond and/or discuss the situation rather than here on the repo.

from tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.