Rename Render to Renderer about rendy

[zakarumych]

Renderable is what renderer renders

[torkleyy]

Hmm, but it's a trait we're talking about. I think the trait can be called Render and a struct implementing it would then be a renderer. Why does it need to be a noun? 😅

[minecrawler]

It's a little confusing imho, because you don't "build render" ;)

[torkleyy]

Makes sense..

…

On Fri, Oct 26, 2018, 08:32 Marco Alka ***@***.***> wrote: It's a little confusing imho, because you don't "build render" ;) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/rustgd/rendy/issues/11#issuecomment-433301702>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWFFub8LkWKU_1BhCVraQfJ5OUwEy_73ks5uoqxzgaJpZM4X7XTB> .

[LucioFranco]

@termhn at least how I see it, the Render trait is fine, because you can implement Render for some type. Maybe, a better word would be Renderable? but I find that kind of conflicting.

[fu5ha]

I can see the "Render is a trait, Renderer is implementor of said trait" argument, but I still think the name is awkward in most places it will be used. Why not just have the convention be that the implementor (previously Renderer) have a more specific name, since Renderer is very generic. For example impl Renderer for VelorenRenderer or something, depending on what the project/purpose of that Renderer implementation is.

[torkleyy]

I don't mind renaming. @omni-viral What do you think?

[zakarumych]

Since it can be used not only for rendering (thanks to @Rhuagh , how I didn't realize it before) I think it must be renamed to something more general.
I'm open for suggestions.

[fu5ha]

Perhaps Runner since its primary function is to run the passes that have been set up? Alternatively, I thought about Engine, since it's kind of the main driving force behind actually running things, but that seems a bit too abstract to me.

[zakarumych]

This entity doesn't exists anymore