cpplint error when .git directory not present about ament_lint

[dirk-thomas]

Your header files need to be either in a directory (or subdirectory) with a "common" name (incude, src, test, see

ament_lint/ament_cpplint/ament_cpplint/main.py

Line 232 in 3910896

subfolder_names = ['include', 'src', 'test']

) or the root of the repository can be identified (.git, .hg, .svn, see

ament_lint/ament_cpplint/ament_cpplint/main.py

Line 252 in 3910896

for marker in ['.git', '.hg', '.svn']:

). If neither of the two conditions is true it is unclear what to pass as --root to cpplint to derive the "correct" header guard from.

[sagniknitr]

@dirk-thomas ok.Got it.

[sagniknitr]

Just a experiment I tried..... I removed the .git folder from the rcl package in the ros 2 ardent release source code...After that when I run ament test for cpplint I receive the following cpplint errors.

 /home/sagnik/Work/ROS/ros2_ardent_alvacore/install/bin/ament_cpplint --xunit-file /home/sagnik/Work/ROS/ros2_ardent_alvacore/build/rcl/test_results/rcl/cpplint.xunit.xml
3: /home/sagnik/Work/ROS/ros2_ardent_alvacore/src/ros2/rcl/rcl/include/rcl/allocator.h:15:  #ifndef header guard has wrong style, please use: __HOME__SAGNIK__WORK__ROS__ROS2_ARDENT_ALVACORE__SRC__ROS2__RCL__RCL__INCLUDE__RCL__ALLOCATOR_H_  [build/header_guard] [5]

and the final result comes as

3 - cpplint (Failed)
Errors while running CTest

It seems that the cpplint test will exclusively look for the .git folder at the root of the package.

[dirk-thomas]

Thank you for pointing this out. Looking at the logic to determine the root it really seems broken to me. Please see #94 for a patch. It would be great if you could give it a try and confirm if resolves the problem for you.

[sagniknitr]

@dirk-thomas Initial testing with the patch is working fine.The Cpplint errors are gone now.
Thank you for the patch.

[dirk-thomas]

Thank you for trying the patch and reporting back.