Coder Social home page Coder Social logo

Comments (6)

esteve avatar esteve commented on August 28, 2024

CI Linux job:

http://ci.ros2.org/job/ros2_batch_ci_linux/492/

from ament_lint.

dirk-thomas avatar dirk-thomas commented on August 28, 2024

The CI job has no effect since ament_cpplint is not enabled as a common linter.

from ament_lint.

esteve avatar esteve commented on August 28, 2024

But it failed, so running the CI job is always a good a idea. Anyway, I'll fix the compile errors.

from ament_lint.

dirk-thomas avatar dirk-thomas commented on August 28, 2024

I expected you to compile the code locally before creating the PRs. In order to run ament_cpplint in the CI it needs to be added to https://github.com/ament/ament_lint/blob/master/ament_lint_common/package.xml But several packages will have other cpplint errors until the pending items on ros2/ros2#12 are addressed.

from ament_lint.

esteve avatar esteve commented on August 28, 2024

I expected it wouldn't fail, but mistakes happen.

from ament_lint.

esteve avatar esteve commented on August 28, 2024

Errors fixed and compiles locally.

from ament_lint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.