Comments (6)
CI Linux job:
http://ci.ros2.org/job/ros2_batch_ci_linux/492/
from ament_lint.
The CI job has no effect since ament_cpplint
is not enabled as a common linter.
from ament_lint.
But it failed, so running the CI job is always a good a idea. Anyway, I'll fix the compile errors.
from ament_lint.
I expected you to compile the code locally before creating the PRs. In order to run ament_cpplint
in the CI it needs to be added to https://github.com/ament/ament_lint/blob/master/ament_lint_common/package.xml But several packages will have other cpplint errors until the pending items on ros2/ros2#12 are addressed.
from ament_lint.
I expected it wouldn't fail, but mistakes happen.
from ament_lint.
Errors fixed and compiles locally.
from ament_lint.
Related Issues (20)
- Ament-flake8 attributeError Humble HOT 4
- Support for other filetypes for ament_copyright HOT 2
- ament_uncrustify is incompatible with uncrustify >= 0.75 HOT 1
- ament_pep257 crashes during xunit generation when non-pep257 errors occur
- What is the general release strategy? HOT 1
- ament_xmllint stuck when no internet
- Feature Rquest: ament_cmake_clang_tidy, specify --header-filter and --jobs options to ament_clang_tidy
- (ament_xmllint) add extension argument
- ament_cmake_pep257, ament_cmake_lint_cmake, ament_cmake_xmllint ignores value of AMENT_LINT_AUTO_FILE_EXCLUDE HOT 1
- ament_flake8 fails with flake8>=6.0.0 HOT 5
- ament_lint_auto finds recursive test dependencies causing downstream packages to inherit conflicting linters
- ament_copyright does not recognize REUSE-compliant copyright headers
- TypeError on debian11 HOT 1
- EXCLUDE argument parsed differently in different linters HOT 2
- BSD 3 license (and maybe others) require a copyright notice at the top of the license file HOT 2
- ament_lint_cmake doesn't display reasons for error when run through pre-commit HOT 1
- xmllint Requires member_of_group to be before export HOT 8
- ament_pep257 uses deprecated pydocstyle HOT 1
- `InsertNewlineAtEOF` entry seen as invalid argument HOT 1
- --exclude negates the target path HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ament_lint.