Comments (3)
Do you think this is related to the uncrustify configuration file provided by the package or a bug in uncrustify itself? If it is the latter please create a ticket in the upstream uncrustify repository instead.
from ament_lint.
Investigating... It may even be a bug of the pinned version of uncrustify
in uncrustify_vendor
. Nevertheless, even if it's a problem in the upstream code, it's a functional shortcoming that ought to be documented against ament_lint
somehow, since the intent is to faithfully enforce the coding standards.
from ament_lint.
Alright. It seems that uncrustify (current HEAD version) does not treat object direct initialization (of the form var Class(args ...)
) as function calls for purposes of nl_func_call_start_multi_line
and I can't find a configuration option
I can see 3 possible resolutions. I'm leaning toward 2 or 3:
- I'm interpreting the developer guide wrong and the formatting guidelines for function calls differ from direct initialization.
- This is a bug in uncrustify and direct initialization should be considered function calls.
- This is a missing feature in uncrustify, and we can't expect the uncrustify linter to enforce this part of the developer guide.
from ament_lint.
Related Issues (20)
- [ament_uncrustify] returns different result between galactic and humble HOT 2
- [ament_clang_tidy] [space_ros] ament_clang_tidy/main.py xml->SARIF assumes single line output from clang_tidy
- Running ament_clang_tidy results in Could not find 'clang-tidy-6.0' executable
- [ament_clang_tidy] Does not print errors and warnings in the terminal
- Add support for a yaml linter
- ament_pep257 support for user defined config file
- `ament_copyright --add-copyright-year` broken
- Restrict allowed licenses in `ament_copyright`
- `ament_copyright` custom entry-point is not available while unit-testing its workspace
- clang_tidy XML to SARIF conversion doesn't match the SARIF spec
- ament_cmake_flake8 ignores value of AMENT_LINT_AUTO_FILE_EXCLUDE HOT 5
- `ament_clang_format` and `colcon test` HOT 4
- [ament_cppcheck] provide libraries
- Update humble ament_pep257 package HOT 5
- Please tag a new release of `ament_lint` for `foxy` HOT 2
- Ament-flake8 attributeError Humble HOT 4
- Support for other filetypes for ament_copyright HOT 2
- ament_uncrustify is incompatible with uncrustify >= 0.75 HOT 1
- ament_pep257 crashes during xunit generation when non-pep257 errors occur
- What is the general release strategy? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ament_lint.