Comments (2)
A few questions coming to my mind:
- How much of the actual implementation can be unified, e.g. for generating the result file?
- If they would be unified where should these shared functions live? Currently the linter packages don't have a common dependency.
- Is the extra effort of maintaining the additional API worth deduplicating some (fairly simple) code snippets?
from ament_lint.
- I believe that all of the above functions can each be unified - the core functionality of each one is identical especially for
get_files
andfind_executable
.get_xunit_content
would require certain code changes within each linter so that a standard way of formatting thereport
variable can be used. - Possibly within a separate directory within
ament_lint
? - Not sure that much maintenance other than what is already being done would be required. It could be argued that this new maintenance whether additional or not is outweighed by the ease of updating all linters xunit output in one swipe
from ament_lint.
Related Issues (20)
- [ament_clang_format] Support pointing to config file rather than YAML load/dump for clang-format>=14.0.0
- Cannot compile on Fedora 36 HOT 1
- [ament_pep257] ament_pep257 not showing errors as stderr HOT 1
- How to ament_cmake_cpplint with filters from CMakeLists HOT 1
- [ament_copyright] does not check LICENSE or CONTRIBUTING.md when package not at root HOT 5
- [ament_cppcheck] add --enable=style HOT 2
- [ament_pep257] make pep257 default in ament_pep257 HOT 2
- ament_flake8 fails with flake8>=5.0.0 HOT 2
- [ament_uncrustify] returns different result between galactic and humble HOT 2
- [ament_clang_tidy] [space_ros] ament_clang_tidy/main.py xml->SARIF assumes single line output from clang_tidy
- Running ament_clang_tidy results in Could not find 'clang-tidy-6.0' executable
- [ament_clang_tidy] Does not print errors and warnings in the terminal
- Add support for a yaml linter
- ament_pep257 support for user defined config file
- `ament_copyright --add-copyright-year` broken
- Restrict allowed licenses in `ament_copyright`
- `ament_copyright` custom entry-point is not available while unit-testing its workspace
- clang_tidy XML to SARIF conversion doesn't match the SARIF spec
- ament_cmake_flake8 ignores value of AMENT_LINT_AUTO_FILE_EXCLUDE HOT 5
- `ament_clang_format` and `colcon test` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ament_lint.