Coder Social home page Coder Social logo

Comments (2)

dirk-thomas avatar dirk-thomas commented on July 24, 2024

A few questions coming to my mind:

  • How much of the actual implementation can be unified, e.g. for generating the result file?
  • If they would be unified where should these shared functions live? Currently the linter packages don't have a common dependency.
  • Is the extra effort of maintaining the additional API worth deduplicating some (fairly simple) code snippets?

from ament_lint.

JShep1 avatar JShep1 commented on July 24, 2024
  • I believe that all of the above functions can each be unified - the core functionality of each one is identical especially for get_files and find_executable. get_xunit_content would require certain code changes within each linter so that a standard way of formatting the report variable can be used.
  • Possibly within a separate directory within ament_lint?
  • Not sure that much maintenance other than what is already being done would be required. It could be argued that this new maintenance whether additional or not is outweighed by the ease of updating all linters xunit output in one swipe

from ament_lint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.