Coder Social home page Coder Social logo

Comments (8)

schmidt avatar schmidt commented on August 30, 2024

This is especially important, since I wanted to test may changes in http://github.com/finnlabs/recaptcha/commit/96e237ecb60414ce27252f9a272e10951f323eab

from recaptcha.

ambethia avatar ambethia commented on August 30, 2024

That's interesting, there should be no problem requiring rails/version if rubygems is loaded, and the rails gem installed. I do know that some of the tests are broken in the master branch with the introduction of using flash instead of the session to pass the error message back to the user.

from recaptcha.

schmidt avatar schmidt commented on August 30, 2024

Thanks for the hint. I digged a little deeper. It seems to be related to 1.8.7 - when using 1.8.6 the tests are run successfully.

I will try to find a workaround.

from recaptcha.

schmidt avatar schmidt commented on August 30, 2024

Why is the

require 'rails/version'

actually needed. The tests run fine without it. Also, I cannot find any reference to Rails::VERSION in the source of Recaptcha.

from recaptcha.

ambethia avatar ambethia commented on August 30, 2024

It probably referenced at some point, but got factored out of the tests. I'm planning on putting some time aside in the coming days to cleanup the tests and fix up the code in preparation for rails 3.

from recaptcha.

schmidt avatar schmidt commented on August 30, 2024

Okay, with your help, I figured it out

from recaptcha.

schmidt avatar schmidt commented on August 30, 2024

Please also consider integrating my changes to the configuration options before starting any refactoring. http://github.com/finnlabs/recaptcha/commit/96e237ecb60414ce27252f9a272e10951f323eab

from recaptcha.

jjulian avatar jjulian commented on August 30, 2024

+1 for the schmidt configuration changes! Setting the ENV is currently not easy when you have multiple environments and multiple developers running under non-localhost domains.

from recaptcha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.