maxEmptyLines doesn't seem to work about rollup-plugin-cleanup

[aMarCruz]

@DxCx hi.
Please show the file and the rollup.config.js that generates the issue?

In my tests maxEmptyLines is working Ok.

[DxCx]

well i was trying to see graphql-js's bundled size.
so i setup rullup, with babel, to compile the src directory of this repo:
https://github.com/graphql/graphql-js

so essentially it looks like:

import nodeResolve from 'rollup-plugin-node-resolve';
import commonjs from 'rollup-plugin-commonjs';
import babel from 'rollup-plugin-babel';
import cleanup from 'rollup-plugin-cleanup';
import filesize from 'rollup-plugin-filesize';
import progress from 'rollup-plugin-progress';

export default {
    entry: 'graphql/src/index.js',
    format: 'cjs',
    plugins: [
      filesize(),
      progress(),
      nodeResolve({ jsnext: true, module: true }),
      commonjs({
        include: 'node_modules/**',
      }),
      babel({
        babelrc: false,
        runtimeHelpers: true,
        plugins: [
          [test.hackPlugin],
          "syntax-async-functions",
          "transform-class-properties",
          "transform-flow-strip-types",
          "transform-object-rest-spread",
          "transform-es2015-template-literals",
          "transform-es2015-literals",
          "transform-es2015-function-name",
          "transform-es2015-arrow-functions",
          "transform-es2015-block-scoped-functions",
          ["transform-es2015-classes", {loose: true}],
          "transform-es2015-object-super",
          "transform-es2015-shorthand-properties",
          "transform-es2015-duplicate-keys",
          "transform-es2015-computed-properties",
          "check-es2015-constants",
          ["transform-es2015-spread", {loose: true}],
          "transform-es2015-parameters",
          ["transform-es2015-destructuring", {loose: true}],
          "transform-es2015-block-scoping",
          "transform-regenerator",
          "transform-es3-property-literals",
          "external-helpers",
        ],
      }),
      cleanup({
        maxEmptyLines: 1,
        comments: "none",
      }),
    ],
    dest: 'dist/bundle.js',
    external: ['iterall'],
};

[aMarCruz]

@DxCx , it is working, but not as you want.
cleanup processes file by file and rollup concatenates them in a final stage, inseting blank lines between files.
Even more, it seems that the first block of bundle.js (containing classCallCheck) is inserted after cleanup did its job.

I did a test with maxEmptyLines:0 and the output is ok inside each file.

Example in original graphql/src/lenguage/lexer.js:

output in dist/bundle.js:

To act on the generated bundle, it is necessary for cleanup to work in the last rollup phase, for which it has no support, but this is something I have planned for the next minor version that will be released soon.

I will close this issue now and will ping you when the next version is ready.
Thanks for your feedback!

[DxCx]

sure, thanks for the support @aMarCruz :)