Comments (9)
Saubhagya,
I believe the qmass,source is in units of m/s. Can you point out where in the code you see this problem?
Thanks
Sergi
from ats.
Did this get solved?
from ats.
Ok, I think I see the confusion. If this is surface flow, we often use m/s as the mass source unit (e.g precipitation is typically recorded in m/s). But in the subsurface we assume that the mass source is in units of mol/m^3/s. And more generally, because our mass flow equation conserves mols of water, we require sources in mol/(volume unit)/s. So it is somewhat of an accident that this works as is for surface water.
I think I agree with Saubhagya here that we're missing a factor of 1/density, at least by default, and the user should have to tell us if they want to give a mass source in m/s.
from ats.
from ats.
Once this issue is closed and changed are merged in the master, the input file for one of the sorption regression test need to be updated. Value of molar density of water need to be changed from 1 to 55500.
https://github.com/saubhagya-gatech/ats-regression-tests/blob/7bd34016dbb8e00432427ccad358b0a26f1bc90c/07_reactive_transport/reactive_transport-subsurface_sorption_logical.xml#L402
from ats.
Note this test has now been merged into ats-regression-tests master, so we'll have to update the test when @dasvyat rt-fixes branch pull request comes in.
from ats.
@smolins Sergi, I just wanted to point out that this is now closed for real, which likely breaks your test. For surface flow and coupled reactive transport, the "water source in meters" must be set to false, and the units of the water source must be in [mol m^-2 s^-1]. I recognize that this may be a bit annoying, but it is the natural unit of the source (as every other PDE is defined this way). If I can, I will try to find a way to have the MPC check for this option, and ensure it is correctly set in the flow PK.
I now believe that setting "water source in meters" to default to true was a mistake, and hopefully will likely change that default to false soon. It is a bit hard to change defaults though, because it is hard to catch input files that depended upon it...
The easiest way to fix your test would be to simply create an evaluator, e.g.:
<ParameterList name="water_source" type="ParameterList">
<Parameter name="field evaluator type" type="string" value="multiplicative evaluator" />
<Parameter name="evaluator dependencies" type="Array(string)" value="{surface-precipitation_rain, surface-molar_density_liquid}" />
</ParameterList>
Or something similar that multiples your current source (in m/s) times the density (mol / m^3) to get the right units (mol / m^2 / s).
from ats.
Ok, maybe I'm backtracking on this and will add a matching option to transport "water source in meters". This thing must however default to false (because it makes no sense in the subsurface case, it cannot be true there). So if you're doing surface transport, you can set this to true manually, which matches the default in flow.
from ats.
from ats.
Related Issues (20)
- Spack fails to collect ATS version info HOT 1
- domain sets hang on vis-ing individual columns HOT 1
- add evaluators for interpolation in time, use them in ats transport
- Running ATS in cluster promtps me with missing libraries HOT 2
- enforce negative depth for nonplanar faces
- Supersaturated water HOT 2
- Why the installation of ATS failed? HOT 4
- restarted observations with "integrated in time" are bad for the first observation HOT 1
- Add B&C WRM, allow magic omega rel perm model to use B&C lambda
- richards hydrostatic ICs use cell_centroid
- aspect incorrect in the upper left quadrant HOT 1
- ApplyInverse() return code
- Restore CI for new TPLs on david/amanzi-tpls-0.98.8 branch
- refactor transport HOT 1
- Misses by Input File Convertors HOT 2
- "restart from checkpoint file" not working HOT 1
- tests requiring geochemistry still run when compiling with --disable-geochemistry HOT 1
- Can ATS write output directly for ESSDIVE?
- elm_ats_driver still has boost dependencies HOT 2
- elm_ats_driver requires updates regarding Teuchos and Amanzi mesh refactor HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ats.