Coder Social home page Coder Social logo

Comments (11)

itsnitinr avatar itsnitinr commented on May 30, 2024

I would like to work on this.

from react-builder.

TheNinza avatar TheNinza commented on May 30, 2024

I would love to work on this, too... Can you assign me this please

from react-builder.

ananya0504 avatar ananya0504 commented on May 30, 2024

Hi, I have recently started to work on UI. Can I suggest a design for the same?

from react-builder.

itsnitinr avatar itsnitinr commented on May 30, 2024

@amanjagdev You would like me to make any styling improvements?
darkmode

from react-builder.

amanjagdev avatar amanjagdev commented on May 30, 2024

@itsnitinr I would suggest you also change the input boxes and their background to a darker one and that toggle switch's alignment,ent looks a bit off to me, rest everything looks great.
@ananya0504 If you have also started working on it, You can always share the Screen Shot or make a PR for the same
Whosoever PR's UI design will be better will be accepted.

@TheNinza As you can see 2 people have already started working on it.
So I would suggest you can work on some other issue that will be opened in a while.

from react-builder.

itsnitinr avatar itsnitinr commented on May 30, 2024

@amanjagdev Kindly check this out and let me know if anything else needs to be changed. The theme persists on reload.
ezgif com-gif-maker

from react-builder.

lakbychance avatar lakbychance commented on May 30, 2024

Hey @amanjagdev I have raised a pull request #18 for this issue.
Let me know if this works for you.
One thing I couldn't figure out was toggling github button theme without page reload so I have not implemented it. The 'data-color-theme' was not picking up the changes without reloading the page.

from react-builder.

itsnitinr avatar itsnitinr commented on May 30, 2024

Hi @lapstjup. Even I've resolved the issue over an hour ago. I was unaware that you were also working on it as you didn't leave a comment saying so. I was waiting for @amanjagdev's approval before I make a PR. I've sent a GIF above of the same.

from react-builder.

lakbychance avatar lakbychance commented on May 30, 2024

Hey @itsnitinr no worries. I suppose @amanjagdev will choose according to his metrics of selection. I guess you should also raise a pull request for the same 😄. In case I had to first ask to pick up the issue then it's my fault 😅 .

from react-builder.

amanjagdev avatar amanjagdev commented on May 30, 2024

@itsnitinr and @lapstjup I haven't assigned the particular issue to anyone, so technically all of you can make corresponding PRs
but @itsnitinr is correct, Its always a good practice to mention and discuss things in the issue first before making a PR.

This time I will be considering all your pull requests for review and would suggest some changes.
The best PR would be accepted and merged into the main branch.

from react-builder.

amanjagdev avatar amanjagdev commented on May 30, 2024

This issue has been resolved by PR #18

from react-builder.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.