Comments (8)
I wasn't sure whether to include the history results by default. I made it searchable using the command only to avoid showing any sensitive data. Some users have raised concerns about the extension even having access to the browser history to begin with (for privacy reasons), so I am not sure how to feel about it.
Open to changing it though, unsure what people think!
from omni.
Yeah, could work. I think ideally I'd like to have a way for users to decide what they want to see, so they can customize if they see bookmarks, history, actions... and even in which specific order they want it to be. Not sure where that could go though, it would have to be prompted after install and accessible somewhere, probably as an action in the omnisearch, but maybe also through a popup by clicking on the icon in the toolbar, not sure.
Options page might be nice? That could also have other settings that would make the ux a little nicer in general like:
- Themes (custom too?)
- Icon theme (instead of emojis maybe some phosphor icons or something)
- Search mode (for slow/fast computers)
- Fuzzy
- Exact
- What to search:
- Bookmarks
- History
- Tabs
- (request optional permissions if needed when checking)
- Revoke permissions button (revokes all except tabs)
- Customize keyboard shortcuts (might be tricky to implement though)
Perhaps settings could use something like this:
https://github.com/Explosion-Scratch/tab_grouping/blob/main/settings.html#L3-L11 (see settings.js
for the code which I used to keep track of changes)
from omni.
Try typing /history
before searching:
from omni.
You could make some sort of dropdown on the left of the search bar, then when the user tries to activate history ask for an optional permission
from omni.
Yeah, could work. I think ideally I'd like to have a way for users to decide what they want to see, so they can customize if they see bookmarks, history, actions... and even in which specific order they want it to be. Not sure where that could go though, it would have to be prompted after install and accessible somewhere, probably as an action in the omnisearch, but maybe also through a popup by clicking on the icon in the toolbar, not sure.
from omni.
Maybe: ask for history permission, if granted – include history into search results?
from omni.
Also, maybe the previous code only searched from nearly 1000 history records. This should be a trade-off from the performance aspect, but the PR#70 should solve this problem, quickly search from all records, whether it is 20,000 or more Two hundred thousand.
from omni.
+1 on having history searched directly from the search bar.
from omni.
Related Issues (20)
- What is the logic of direct search results?
- [Suggestion] Add command to move tab to another window HOT 1
- favIconUrl is sometimes undefined on action (tab) (Firefox only?) HOT 1
- Option to remove a bookmark
- Google Docs Header Switching
- [Suggestion] Add chatGPT command
- Feature Request: Custom inputs for Commands HOT 1
- exams
- New bookmarks have not been updated
- Plugin doesn't open sometimes
- [feature request] fuzzy search
- Unexpected requests to `/users/undefined` causing unwanted 404 in Rails-based webapp
- The style displayed when bookmarking the protected script is incorrect
- Doesn't work in new tab
- how to open tab when search? HOT 1
- Feature Request: Integrate actions with Firefox Containers
- Chrome extension
- Some settings ?
- Incorrect system theme on Gnome HOT 1
- Invalid browser settings URI on Firefox
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from omni.