Coder Social home page Coder Social logo

Comments (11)

cyrush avatar cyrush commented on June 25, 2024

We can fix this, adapt in the case that connectivity does not match what VTK-m needs regardless of underlying type.

On most platforms we compile with ints are 64-bits, Windows is the main exception i know of, what platform are you compiling on?

from ascent.

mlohry avatar mlohry commented on June 25, 2024

platform:

~/dev/ascent/build$ sysctl -n machdep.cpu.brand_string
Apple M2 Max
~/dev/ascent/build$ sw_vers
ProductName:		macOS
ProductVersion:		13.6.2
BuildVersion:		22G320

from ascent.

cyrush avatar cyrush commented on June 25, 2024

thanks & is this with clang or gcc (I noticed you also hit #730, which seems to be unique to gcc on macos)

from ascent.

mlohry avatar mlohry commented on June 25, 2024

This is with homebrew gcc-12, and the "classic" xcode linker.

#730 I've temporarily worked around by commenting out the template class FLOW_API DataWrapper<conduit::Node> declaration.

from ascent.

haampie avatar haampie commented on June 25, 2024

Seems to happen in Spack CI too:

https://gitlab.spack.io/spack/spack/-/jobs/9702178

[email protected] with GCC 11.4.0 on Ubuntu 20.04 / x86_64 with [email protected].

(Edit: ok, in that case vtk-m was forced to have 64 bits ints... nevermind)

from ascent.

mlohry avatar mlohry commented on June 25, 2024

Hi @cyrush , looking back I'm unclear on this statement

On most platforms we compile with ints are 64-bits

but it looks like the build state now is that ascent requires VTKm to be built with -DVTKm_USE_DEFAULT_TYPES_FOR_ASCENT=ON which is incompatible with -DVTKm_USE_64BIT_IDS=ON, so I takethis to mean the only thing supported today is 32-bit ids, not 64, is that right? Any plans for 64 bit index support in the near future or should I work around it for now?

from ascent.

cyrush avatar cyrush commented on June 25, 2024

@mlohry that is correct, I am sorry I had this flipped in my brain.

We should remove the limit as to how VTK-m is compiled and in our expected use.

We should move to admit both styles, acknowledging that one may be more performant (since VTK-m needs a primary selection)

I will see if we can get this done in 0.9.3.

We are waiting on a few key third party libs updates (raja) to release 0.9.3.

from ascent.

mlohry avatar mlohry commented on June 25, 2024

Sounds good @cyrush , I'll work around it for the time being. Happy to test a branch fix when the time comes.

from ascent.

cyrush avatar cyrush commented on June 25, 2024

I looked into this:
That logic was preventing VTK-m dataset with non int connectivity from being converted back to Blueprint.

Blueprint does support a broad range of integer types as connectivity arrays -- this logic in Ascent is a hold over from a while back. I am removing the guard in #1290.

Additionally, Ascent does accept non int connectivity from Blueprint meshes and can convert those to VTK-m. So round trip between these formats should not be an issue.

from ascent.

cyrush avatar cyrush commented on June 25, 2024

resolved in #1290

from ascent.

mlohry avatar mlohry commented on June 25, 2024

Thank you @cyrush !!

from ascent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.