Coder Social home page Coder Social logo

Comments (3)

saulius avatar saulius commented on July 24, 2024

Can't we just set TRADE_TARIFF_USER and TRADE_TARIFF_PASSWORD (https://github.com/alphagov/trade-tariff-admin/blob/master/config/application.rb#L84) instead of uploading whole config file?

from trade-tariff-admin.

jabley avatar jabley commented on July 24, 2024

Needs to change to use OAuth anyway, rather than Basic Auth.

Basic Auth is being dropped from GDS SSO.

from trade-tariff-admin.

saulius avatar saulius commented on July 24, 2024

I'd gladly move them to OAuth, but I'm not sure what OAuth scheme should Tariff setup use. We protect tariff-admin with OAuth2 web flow and that works ok. But we also want to protect parts of the API (write side mostly) with OAuth2 as well (they are now protected with Basic Auth as James mentioned). How should this work with OAuth? Access tokens are issued per app, per user so I can't pass Tariff Admin's token to the API as bearer token unless we use same client_id and client_secret for both tariff-admin and tariff-backend. I'm really not an expert on this cross-app OAuth communication so any help would be appreciated.

from trade-tariff-admin.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.