Comments (10)
@adamsilver what's your reasoning?
from accessible-autocomplete.
If we're going to put "accessible" in the name then why not put other things in it too:
- "well-designed-autocomplete"
- "really-good-progressively-enhanced-responsive-autocomplete"
- "fast-well-tested-autocomplete"
Accessible is one of many qualities of a well designed component. Why emphasis this one aspect?
from accessible-autocomplete.
Might be worth a discussion with Alice and Tim.
It being an accessible typeahead is arguably the main selling point. More than that, where there have been design dilemmas, we've erred on the side of accessibility. Some of the features we might have wanted to do we couldn't because of this.
We could go with govuk-autocomplete
but we're hoping this component may be generically useful outside of government too, so not having govuk
in the name may be helpful.
from accessible-autocomplete.
Also need to republish the package on npm
from accessible-autocomplete.
Also don't put "Accessible" in front of it.
from accessible-autocomplete.
I think accessible
is great for marketing (people search for "accessible <thing>" all the time). It also makes accessibility non-negotiable, because it's right there in the name.
from accessible-autocomplete.
Fair enough. Will GDS (re)name all components "accessible-etc"?
from accessible-autocomplete.
it does seem odd, and would mean we'd have to name other components accessible-
from accessible-autocomplete.
@joelanman @adamsilver I disagree we'd have to extend the naming. We don't follow strict guidance on naming projects as far as I'm aware of? Separate discussion about this can be had but until then projects get named all sorts of things. (govuk-
in projects that aren't used by GOV.UK is another weird theme)
Autocompletes are notoriously hard to get right from an accessibility standpoint. I think it's worth leveraging this as a selling point. I also think the alliteration in accessible-autocomplete
is catchy.
Or we can go for gds-autocomplete
, or govuk-autocomplete
, tbh this is a bikeshed discussion. Picking a name is important but being stuck debating isn't useful.
from accessible-autocomplete.
govuk would be more consistent with other things we provide (elements, prototype kit, notify, etc) and I don't think it stops usage outside of government. It could be useful for people to be aware of where this good work comes from.
from accessible-autocomplete.
Related Issues (20)
- @rebase
- React component - Invalid ARIA attribute value: aria-activedescendant="false" HOT 1
- How to set new displayed input value on confirm
- unsetting the value that is been set is not working
- Dynamically set the autocomplete value
- WCAG 2.2: Scroll bar within combobox is difficult to activate, due to width (15px wide) HOT 2
- Value of input not being updated by Dragon NaturallySpeaking HOT 18
- Is there anyway to make the assistiveHint attribute optional? HOT 1
- Can't set up dev environment/fibers won't compile HOT 8
- hook for keyboard down or when user start typing HOT 1
- showAllValues not working
- Finalise CHANGELOG content ahead of release
- Query: Entering 'autocomplete list box' on desktop & mobile devices
- Run test against latest version 10.x of Preact
- Run test against newer versions of React
- Release new version of accessible autocomplete HOT 2
- Two screenreader user reccomendations on results
- Ensure tests fail when an uncaught error or unhandled rejection happens in the browser
- Suggestion list disappears when clicking scrollbar in chrome
- Focus management on list dismissal (Escape Key)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accessible-autocomplete.