Coder Social home page Coder Social logo

Comments (10)

neeschit avatar neeschit commented on September 3, 2024

@shlomikushchi - curious on your thoughts on this.

from alpaca-trade-api-js.

shlomiku avatar shlomiku commented on September 3, 2024

let's talk. can you contact me on the alpaca slack channels?

from alpaca-trade-api-js.

anonrose avatar anonrose commented on September 3, 2024

Hi, is this moving forward? If not I'll be forking and implementing myself.

from alpaca-trade-api-js.

neeschit avatar neeschit commented on September 3, 2024

btw have you seen this?

https://github.com/117/alpaca

from alpaca-trade-api-js.

anonrose avatar anonrose commented on September 3, 2024

@neeschit I haven't, I'm going to move forward with that. Thank you!

from alpaca-trade-api-js.

neeschit avatar neeschit commented on September 3, 2024

Out of curiosity, what versions of Node does this library support? @shlomikushchi

from alpaca-trade-api-js.

neeschit avatar neeschit commented on September 3, 2024

let's talk. can you contact me on the alpaca slack channels?

To summarize what we spoke offline, maintaining backwards compatibility takes priority over migrating to ESM. We will need to publish a hybrid npm package.

The approach I was looking to use is somewhat detailed here:

https://2ality.com/2019/10/hybrid-npm-packages.html#option-2%3A-bare-import-commonjs%2C-deep-import-esm-(maximum-backward-compatibility)

I will try to create a PR when I have time

from alpaca-trade-api-js.

shlomiku avatar shlomiku commented on September 3, 2024

@neeschit I am unaware of any limitations right now, but if you are - let me know so we could document it.

from alpaca-trade-api-js.

neeschit avatar neeschit commented on September 3, 2024

Ok, it would be great if we could limit support to Node 12+ or even better, Node 14+ which is now LTS/Default recommended on https://nodejs.org/en/.

If we are comfortable doing that @shlomikushchi, I can cut a PR to migrate to ES modules, building on the work by @anonrose to tweak the package.json to support both CJS and ESM

from alpaca-trade-api-js.

shlomiku avatar shlomiku commented on September 3, 2024

image

node 10 eol is in a few months, so that makes sense moving forward. node 12 has more than a year, so it is better to keep that

from alpaca-trade-api-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.