[Bug]: StockHistoricalDataClient produces a wrong URL about alpaca-py

[sshcli]

@peters-r try whith the TimeFrameUnit:

from alpaca.data.timeframe import TimeFrame              
from alpaca.data.timeframe import TimeFrameUnit   
StockBarsRequest(symbol_or_symbols=[SYMBOL],timeframe=TimeFrame(1, TimeFrameUnit.Day), start=START, end=END)

[alessiocastrica]

This is expected TimeFrame is not an Enum, but TimeFrameUnit is.

[alessiocastrica]

@peters-r I agree with you that having the same name can be confusing, but changing the API would be a breaking change that I would prefer to avoid right now.
The TimeFrame Day class property was actually imagined as a shortcut, please check out the implementation here.
So in your case you can just use timeframe=TimeFrame.Day
Hope this helps.

[peters-r]

So it's not a bug, but still I think the API is highly confusing in that regard. Maybe could be worth to at least make sure that TimeFrameUnit and TimeFrame don't have the same 'Day' property or to make it more explicit that one is an enum and the other isn't. Or to update the docs to make it more obvious. I probably wouldn't have filed a bug if I found it in the docs.

It works for me now. Thanks for your quick support!