Coder Social home page Coder Social logo

Comments (7)

thepycoder avatar thepycoder commented on August 25, 2024

Hi @amirhmk!

The model extentions are hardcoded based on the framework type of the model in ClearML.
You have 2 options:

  • Override the default filename as in the example here, you'll see the config override in the CLI commands
  • Or you can manually specify the model framework when you upload it, set framework argument to 'onnx' and it should properly rename it!

EDIT: I just saw that your framework in clearml is properly set. That's weird and probably a bug on our end. Please check if the first fix works for you, we'll investigate the second :)

Hope this helps! :)

from clearml-serving.

amirhmk avatar amirhmk commented on August 25, 2024

Hi @thepycoder, option 1 worked, thanks! Adding default_model_filename: "model.bin" to config.pbtxt and passing it as a file was fine. Though regarding your second point, did onnx models use to have the .bin extention that this is setup like this?

Also as a small aside, I found out that if one passes a file (path) for --aux-config, it'll completely copy paste the passed in config file, and still add the input/output shapes/types/names to the bottom of the final config file - resulting in errors. I thought it would make sense to only pass the config file, and not have to even pass all the shapes one-by-one in the command. Wdyt?

from clearml-serving.

thepycoder avatar thepycoder commented on August 25, 2024

option 1 worked, thanks!

Excellent!

Though regarding your second point, did onnx models use to have the .bin extention that this is setup like this?

Possibly yes, this might be a remnant of earlier ONNX days, I'll have to check.

I thought it would make sense to only pass the config file, and not have to even pass all the shapes one-by-one in the command. Wdyt?

Yeah, I think that makes sense, I'll discuss it with the devs :) Thanks a lot for the suggestion!

from clearml-serving.

ainoam avatar ainoam commented on August 25, 2024

I thought it would make sense to only pass the config file, and not have to even pass all the shapes one-by-one in the command. Wdyt?

@amirhmk Aren't these already optional CLI parameters? i.e. you don't have to specify them if their already specified in the config file.

from clearml-serving.

amirhmk avatar amirhmk commented on August 25, 2024

@ainoam so most of those are, but the input(or output) shapes/types are mandatory.

from clearml-serving.

ainoam avatar ainoam commented on August 25, 2024

@amirhmk Can you give an example of your CLI invocation, and mark which parameters seem to be unnecessarily mandatory (i.e. also specified in your aux file)

from clearml-serving.

IlyaMescheryakov1402 avatar IlyaMescheryakov1402 commented on August 25, 2024

@ainoam #62

from clearml-serving.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.