Comments (4)
HI @prein
Why not make it case insensitive?
I checked and consul in case insensitive when querying for the service, but it store service name with case. I'm not sure if we should make service name upper or lowercase if user want to have mixed case. Maybe this could be a config option to ignore case and keep everything lowercase.
Another suggestion regarding the naming is to make it more descriptive and specific.
I concur but it won't be backward compatible. The history behind "consul" flag: Initially we thought it will be used only to distinguish tasks that should be handled by marathon-consul, so the name consul was good. Then we added functionality to store service name there and that was a mistake. Short label name was useful from Marathon UI perspective but as you pointed out not clear for user.
Your points are perfectly valid but I afraid we can't fix this without breaking backward compatibility. What do you think? Maybe we can do better job on documentation?
from marathon-consul.
Thanks @janisz. I understand and agree with your concern about backward compatibility. Perhaps adding additional label and making the code ignore the "old" one when the "new" one is found would be good for transitional stage.
Making it clear in documentation is also good idea. Perhaps I wouldn't spend time guessing if it was pointed out there.
from marathon-consul.
Sounds good. We can make it working like this.
@adamdubiel What do you think about this?
@prein Would you like to prepare a patch for it?
from marathon-consul.
I think we could make the name of the label configurable? This way anyone can have it his or hers way (upper case, more descriptive etc). Also it could be a list, so this way we make it easy to transition for one state to another.
However since we are not in immediate need of this feature, i would say this qualifies as best effort type of task and as @janisz proposed, creating a PR would speed up things significantly. Of course we will take care of reviewing & releasing new version once it is merged.
from marathon-consul.
Related Issues (20)
- marathon-consul does not recover from connection refused in leader retrieval HOT 11
- marathon-consul loses connectivity to marathon HOT 14
- please add configurable number of retries/retry interval for marathon connection errors HOT 1
- Remove web handler
- PPA broken HOT 2
- marathon-consul should support multiple marathon clusters HOT 4
- Syncing the TASK_KILLING servcies HOT 5
- Migrate from Glide to dep HOT 2
- Update Consul to 0.9.3
- Update Consul to 1.0.0 HOT 1
- Catalog get operation randomness problematic in heterogenous ACL environments HOT 1
- Parallel tests run into a data race
- marathon-consul sometimes failing updation HOT 1
- USER network mode can't register to consul HOT 4
- Unexpected response code: 500 (rpc error: No path to datacenter): Sync not working, Services not being de-registered HOT 6
- marathon-consul (de)registers consul services in all datacenters HOT 3
- Documents on deployment with consul? HOT 4
- Task ID wrong in health status event HOT 10
- APT repository not signed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marathon-consul.