Coder Social home page Coder Social logo

Comments (3)

allanrbo avatar allanrbo commented on August 23, 2024 1

Good point about pulling out the condition. I have done that now and made a release 1.9. That part of the code isn't very elegant...

Implemented a really simple support for just Host * now. Hopefully that will fulfill some people's needs. Didn't have time to do a full fledged version for things like

  • Host *.example.com
  • Host *.example.*
  • Host somehost.*.com
  • Match host host1.com,host2.com

Those would be nice to have in the future.

from filesremote.

allanrbo avatar allanrbo commented on August 23, 2024

Might be as simple as just adding something like || cur_host == "*" to each of the conditions

} else if (cmd == "hostname" && (cur_host == this->display_host_ || cur_host.empty())) {
...
} else if (cmd == "identityfile" && (cur_host == this->display_host_ || cur_host.empty())) {
...
} else if (cmd == "user" && !username_given && (cur_host == this->display_host_ || cur_host.empty())) {
...
} else if (cmd == "port" && !port_given && (cur_host == this->display_host_ || cur_host.empty())) {

near https://github.com/allanrbo/filesremote/blob/master/src/hostdesc.cpp#L139

from filesremote.

Himura2la avatar Himura2la commented on August 23, 2024

I've been looking at this place, but was not absolutely sure that I understand how it works. Is there any strong reason why we can't extract the cur_host == this->display_host_ || cur_host.empty() || ... part into a local variable defined right before the if/else cascade?

from filesremote.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.