Coder Social home page Coder Social logo

Comments (9)

EndBug avatar EndBug commented on June 10, 2024 1

Btw, here's the evidence of "none" being a valid value, different from "": https://github.com/all-contributors/cli/blob/96534ec59b2e45051d517dee56967e2f9e6da371/src/init/commit-conventions.js#L33

from all-contributors.

EndBug avatar EndBug commented on June 10, 2024 1

Just opened a PR in both repos, we just need to wait for the maintainers ;)

from all-contributors.

Berkmann18 avatar Berkmann18 commented on June 10, 2024 1

That's good to know. I guess it will be even easier once the new project structure comes into effect (not sure yet when that happens as I will try to get the fetching feature moving).

from all-contributors.

EndBug avatar EndBug commented on June 10, 2024

Public schema available here: https://json.schemastore.org/all-contributors.json

from all-contributors.

VeckoTheGecko avatar VeckoTheGecko commented on June 10, 2024

Great feature @EndBug ! Just started using it, and I'm not sure if the schema is 100% accurate. I have "commitConvention": "none" in my config, which I think is valid (according to some of the conversation in this repo) but its not accounted for in the schema. I don't know, maybe its since been deprecated.

The "none" option is also not listed in the documentation, adding to the confusion. Maybe a maintainer can provide some more insight into this.

extra: another repo successfully uses "commitConvention": "none"

from all-contributors.

EndBug avatar EndBug commented on June 10, 2024

Nice catch! Yeah, I built the schema from the docs, which seem to be outdated :/
I'll add "none" to the valid options, and maybe also open a PR to update the docs
Thanks ✨

from all-contributors.

VeckoTheGecko avatar VeckoTheGecko commented on June 10, 2024

Awesome! I was actually crawling through the codebase for "none" but couldn't find it 😄 . Good to know its valid

from all-contributors.

Berkmann18 avatar Berkmann18 commented on June 10, 2024

Would that be synced up whenever the config schema was updated?

from all-contributors.

EndBug avatar EndBug commented on June 10, 2024

Would that be synced up whenever the config schema was updated?

@Berkmann18 Ideally, the project itself would update the public schema for its users. But when that doesn't happen, anyone can submit a PR to SchemaStore/schemastore to update it, kind of like everyone can update DefinitelyTyped type definitions.

If the project wants to commit to updating the schema itself, then we can change the data in SchemaStore so that it will point to this GitHub repo.

from all-contributors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.