Support for Bird2 ipv4 and ipv6 in a single daemon about birdwatcher

[jwieq]

We managed to make it work for now with this awful hack:

diff --git a/bird/parser.go b/bird/parser.go
index d64797e..fc93fba 100644
--- a/bird/parser.go
+++ b/bird/parser.go
@@ -570,6 +570,8 @@ func parseProtocol(lines string) Parsed {

            if isCorrectChannel(ipVersion) {
                    parseLine(line, handlers)

•           } else {
  

•                   parseLine(line, handlers)
            }
    }
  

Am not a go guy so I'm sure there's a better way.

The channel version check isn't happy with ipv4 and ipv6 in the same daemon, but it probably should be. In our purely ebgp deployment, it works perfectly fine once this is applied.

[annikahannig]

I did not have a chance to test this so far. However your patch basically means remove the isCorrectChannel(...) entirely. (if true -> parseLine, if false -> parseLine :-) )

[jwieq]

Pull request submitted. :)

[jwieq]

Quick note here. We found that with our hacked version, that in birdwatcher we could not see filtered ipv6 prefixes still. So we made a further hack to allow filtered v6 prefixes to show up.

jwieq@f463fe7

[tweippert]

With this i see only filtered prefixes on search page. on the Routeserver Peer Page Filtered/accepted Routes are shown as expected. Haven't looked on the code actual

[bluikko]

Would this fix the problem with BIRD2 where IPv4 Alice lists additionally all IPv6 neighbors with 0 routes - and conversely the IPv6 Alice instance lists additionally all IPv4 neighbors with 0 routes?

[netstx]

Would this fix the problem with BIRD2 where IPv4 Alice lists additionally all IPv6 neighbors with 0 routes - and conversely the IPv6 Alice instance lists additionally all IPv4 neighbors with 0 routes?

I am wondering about the same, have had a hard time fixing this, even after choosing "single_table" type and setting the tables to master4 and master6 accordingly (with 2 birdwatcher instances running).

Any help would be much appreciated.

[jwieq]

I don't believe this would change that issue, I'm afraid. Cheers

…

________________________________ From: Rafael ***@***.***> Sent: 31 May 2022 18:02 To: alice-lg/birdwatcher ***@***.***> Cc: Jason Ihde ***@***.***>; Author ***@***.***> Subject: [EXTERNAL] Re: [alice-lg/birdwatcher] Support for Bird2 ipv4 and ipv6 in a single daemon (#28) Would this fix the problem with BIRD2 where IPv4 Alice lists additionally all IPv6 neighbors with 0 routes - and conversely the IPv6 Alice instance lists additionally all IPv4 neighbors with 0 routes? I am wondering about the same, have had a hard time fixing this, even after choosing "single_table" type and setting the tables to master4 and master6 accordingly (with 2 birdwatcher instances running). Any help would be much appreciated. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/alice-lg/birdwatcher/issues/28*issuecomment-1142390904__;Iw!!PcPv50trKLWG!0jeG3BROoL5rU5C5XSUhGnBxzpR38umL3zKp7X27unIourlmxdf6J4BLQBaUjyQf14xEtEinkptBRNGs4PSBX-VXtDFuZg$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABU7OPRQ2UPC4FSYLJO65QTVMZA2RANCNFSM4UBELYNQ__;!!PcPv50trKLWG!0jeG3BROoL5rU5C5XSUhGnBxzpR38umL3zKp7X27unIourlmxdf6J4BLQBaUjyQf14xEtEinkptBRNGs4PSBX-WGMhqNaQ$>. You are receiving this because you authored the thread.Message ID: ***@***.***> This email is from Equinix (EMEA) B.V. or one of its associated companies in the territory from where this email has been sent. This email, and any files transmitted with it, contains information which is confidential, is solely for the use of the intended recipient and may be legally privileged. If you have received this email in error, please notify the sender and delete this email immediately. Equinix (EMEA) B.V.. Registered Office: Amstelplein 1, 1096 HA Amsterdam, The Netherlands. Registered in The Netherlands No. 57577889.

[axu-trex]

Is this issue still half broken, or did someone just forget to close the issue?