Coder Social home page Coder Social logo

Comments (5)

allencloud avatar allencloud commented on May 1, 2024 1

I reassigned this issue to @zhubingbing , and maybe bingbing can help. @Letty5411

from pouch.

allencloud avatar allencloud commented on May 1, 2024

Could you help to solve this for project? @Letty5411

from pouch.

Letty5411 avatar Letty5411 commented on May 1, 2024

@allencloud OK

from pouch.

zhubingbing avatar zhubingbing commented on May 1, 2024
  1. Issue Description
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
pouch/cli/pull.go
Line 94: error: unrecognized printf verb 'r' (vet)
Line 102: error: unrecognized printf verb 'r' (vet)
Line 109: error: unrecognized printf verb 'r' (vet)

i think fmt.Sprintf formate don’t have “r” parameter, so go vet report this issue.
if an operand implements the Formatter interface, it will be invoked. Formatter provides fine control of formatting.(https://golang.org/pkg/fmt/#Fprintf)
and bar.go(https://github.com/containerd/containerd/blob/master/progress/bar.go#L21) to realize formatter interface. so i thinks there's no problems with this code .

from pouch.

allencloud avatar allencloud commented on May 1, 2024

Actually with my own go vet on my local machine, it will report no error:

pouch (master) $ go vet cli/pull.go
pouch (master) $ go version
go version go1.8.3 darwin/amd64
pouch (master) $

So maybe we can ignore this, and please move on on your work. @zhubingbing
Thanks a lot.

from pouch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.