Comments (5)
I reassigned this issue to @zhubingbing , and maybe bingbing can help. @Letty5411
from pouch.
Could you help to solve this for project? @Letty5411
from pouch.
@allencloud OK
from pouch.
- Issue Description
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
pouch/cli/pull.go
Line 94: error: unrecognized printf verb 'r' (vet)
Line 102: error: unrecognized printf verb 'r' (vet)
Line 109: error: unrecognized printf verb 'r' (vet)
i think fmt.Sprintf formate don’t have “r” parameter, so go vet report this issue.
if an operand implements the Formatter interface, it will be invoked. Formatter provides fine control of formatting.(https://golang.org/pkg/fmt/#Fprintf)
and bar.go(https://github.com/containerd/containerd/blob/master/progress/bar.go#L21) to realize formatter interface. so i thinks there's no problems with this code .
from pouch.
Actually with my own go vet
on my local machine, it will report no error:
pouch (master) $ go vet cli/pull.go
pouch (master) $ go version
go version go1.8.3 darwin/amd64
pouch (master) $
So maybe we can ignore this, and please move on on your work. @zhubingbing
Thanks a lot.
from pouch.
Related Issues (20)
- Weekly Digest (16 February, 2020 - 23 February, 2020)
- Errors will happen when upgrading the libraries HOT 1
- Weekly Digest (28 June, 2020 - 5 July, 2020)
- [question]Is Pouch suitable for CDN application?
- Weekly Digest (5 July, 2020 - 12 July, 2020)
- Weekly Digest (12 July, 2020 - 19 July, 2020)
- Weekly Digest (19 July, 2020 - 26 July, 2020)
- Weekly Digest (26 July, 2020 - 2 August, 2020)
- Weekly Digest (2 August, 2020 - 9 August, 2020)
- Adding arm64 job in Travis-ci HOT 1
- no support go 1.15.6 HOT 1
- How to Install pouch on ubuntu18.04 HOT 1
- pouch save failed: an error will be reported every time you download to 14G HOT 3
- Kubernetes 1.22 dose not work with pouch HOT 2
- 不维护了吗 没动静了 HOT 2
- pouch 富容器无法启动 最新的版本 HOT 1
- 不起作用 dumb-init 进程看不到 HOT 1
- Why don't you have thye go.mod file like other Go projects?
- Is there rpm for 1.3.1 version?
- Can I install on MacOS and how to do it?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pouch.