Coder Social home page Coder Social logo

Comments (8)

HusterWan avatar HusterWan commented on May 1, 2024 3

@allencloud @skoo87 i create a pr to fix this problem, please review #160 , if there is any problem, you can ping me any time. 3x

from pouch.

HusterWan avatar HusterWan commented on May 1, 2024 2

also countered this problem, @gaocegege you should pull docker images like:
pouch pull docker.io/library/hello-world:latest
pouch set default registry address: docker.io, but likely not worked

from pouch.

HusterWan avatar HusterWan commented on May 1, 2024 2

there also has a bug: client decode failed, because server return 200 ( should 500)
resp.WriteHeader(http.StatusInternalServerError) // this code does not worked
may i can fix this problem for you @allencloud

from pouch.

allencloud avatar allencloud commented on May 1, 2024

We will improve this part asap. This is a known insufficient.

from pouch.

allencloud avatar allencloud commented on May 1, 2024

It couldn't be better. Just submit PR and enjoy hacking. @HusterWan 👍

from pouch.

gaocegege avatar gaocegege commented on May 1, 2024

@HusterWan Thanks for your information

from pouch.

skoowoo avatar skoowoo commented on May 1, 2024

failed to decode: invalid character 'i' in literal false (expecting 'l') <===== The reason may be that the server side(pouchd) closed the connection, not http status code. The CLI read data from the tcp connection and decode them with json format, but not handle the error when connection closed. @HusterWan Welcome to post a PR to fix it, thanks.

from pouch.

HusterWan avatar HusterWan commented on May 1, 2024

@skoo87 i am working on it, the problem maybe more complicated, golang ResponseWriter allow call WriteHeader only once, so if the server(pouchd)'s goroutine call ResponseWriter.Writer once when pull image, the http code will be set 200, and later call resp.WriteHeader(http.StatusInternalServerError) will not work .
https://golang.org/pkg/net/http/#ResponseWriter

so i am thinking maybe we can not only use http code to judge if pull image is ok

from pouch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.