duplicated symbol error about hessian2-codec

[zyfjeff]

Let me do some research first

[wbpcode]

https://github.com/wbpcode/hessian2-codec/tree/52e51c4602d64db95b5b7484ca8229254fee6a2f

Checkout this repo and commit and run:

bazel build //example/mutiple_src:mutiple_src

It will be multiple definition error.

And checkout to 7ab8660, run above command again, it will be ok. (7ab8660 moved function definition to .cc)

[wbpcode]

If a function template specialization specifies all template parameters, then it is a normal function, not a template. The declaration and implementation should be separated in this case to avoid redefinition errors.

@zyfjeff

[zyfjeff]

@wbpcode You're right. That seems to be the reason.
https://stackoverflow.com/questions/4445654/multiple-definition-of-template-specialization-when-using-different-objects

[wbpcode]

I I have completed a version in which the definitions of related functions have been moved to the cc file. Of course, directly declaring related functions as inline can also solve this problem. If you prefer the former, I can submit a PR directly. If you prefer the latter, May be I can take the time to prepare another PR tomorrow to solve this problem.

@zyfjeff

[zyfjeff]

@wbpcode The former is better, and separating implementation and declaration is a best practice.