Coder Social home page Coder Social logo

Comments (5)

jiangxin avatar jiangxin commented on May 5, 2024 1

Thank you, it sounds perfect. I'm still working on a system with the review protocol, so close when you think it is ready.

Can this review protocol you mentioned work with git-repo? Would you like to add the name of your platform to "git-repo ready" list in a section of the README.md of this repo?

from git-repo-go.

jiangxin avatar jiangxin commented on May 5, 2024

When dealing with e.g. manifest repositories e.g. here on github, where there is no address for review in the manifest,
you currently get ERROR: bad address for review ''.

This is fixed in pull request #12.

git repo upload --remote, gives the impression that it only works with --single repositories, (correct?)
--remote string use specific remote for upload (use with --single)

This is because for single repository, there is no manifest file for it, and there maybe more remotes defined in .git/config. So it's necessary to add "--remote" support for single repository.

Is there a nice way to make --remote work with multiple repositories, and if not do you think adding something such as --remote-manifest-url would be a good way to do so?

For multiple repositories, we can define different remote in localt_manifests/*.xml. We used to raise an error for duplicate remote element, this pull request fixed it. We can override the remote element of the default manifest by provide a local manifest file with a duplicate remote element with 'override' attribute turned on.

See pull request #11.

from git-repo-go.

jiangxin avatar jiangxin commented on May 5, 2024

I will add test cases tomorrow.

from git-repo-go.

ratmice avatar ratmice commented on May 5, 2024

Thank you, it sounds perfect. I'm still working on a system with the review protocol, so close when you think it is ready.

from git-repo-go.

ratmice avatar ratmice commented on May 5, 2024

Just trying to implement AGitFlow so yes, once I've got it working i'll send a PR for the README.md definitely.

from git-repo-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.