issue with dependencies in node_modules about ld-r

[mathib]

I tried to install using the install.bat. I also tried to install it using the manual way with npm install, but also without result. This was the output of npm install:

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN [email protected] requires a peer of request@^2.34 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of request@^2.34 but none is installed. You must install peer dependencies yourself.

added 244 packages in 20.795s

[mathib]

When I try to install webpack and webpack-dev-server locally, I get the following:

C:\Users\USER-NAME\Documents\LD-R\ld-r5>npm install --no-optional --save-dev webpack webpack-dev-server
npm WARN [email protected] requires a peer of request@^2.34 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of request@^2.34 but none is installed. You must install peer dependencies yourself.

up to date in 13.284s

But in the node_modules folder, there is still no webpack or webpack-dev-server

[ali1k]

it seems to be a general npm issue on Windows rather than LD-R issue! Need some time to reproduce it on a Windows machine.

[mathib]

The strange thing is, that with LD-R v1.1.9, I was able to run the app in dev mode (webpack and webpack-dev-server were installed correctly then)...

Anyway, I did a workaround: by manually copying the node_modules folder from the older LD-R project I had (v1.1.9) I could get it going for now. But this can cause issues for new windows users of course.

[ali1k]

I checked this issue again on a Windows 10 machine and all the node_modules were successfully added. The only issue I noticed was setting the env variable for the build mode on windows which sounds problematic. As I see it can set the env car but cannot retrieve it correctly.

[mathib]

It's still not solved for my case... This is a list of the packages that are installed in the node_modules folder:
f.txt
The problem occurs for both dev mode as build mode.

[mathib]

I wanted to give an update on this:

• If I run LD-R on my Mac, it don't give any problems for dev and build mode
• If I want to start using a fresh LD-R clone on my windows 10, it keeps failing on installing the required packages when I run the install script. For some reason, it worked to run LD-R in dev mode earlier on (I think somewhere in January of this year). Any idea on how to proceed on Windows?

P.S. I've found a temporal workaround by just copying the node_modules folder of the older working LD-R instance to the new LD-R. If I do this, I can run LD-R in dev and product mode without any problem (I need the npm run build:windows command if I want to build it). This clumsy method will probably give some issues regarding to dependencies in the future, I guess?
UPDATE: I already had issues by using this workaround. If I want to start a new LD-R (v1.1.12) by copying the node_modules folder of an older LD-R project (v1.1.9), I can run the application in dev mode, but none of the buttons of the facet browser do something; I can still run it in build mode without problems...

[mathib]

@ali1k I have the feeling that it has something to do with my Windows being not able to find the globally installed webpack. If I check the version from the command line, it finds it without problems, but when I run clone LD-R and let it install its packages, it does not add the webpack related packages.

Maybe I can try to install webpack locally, but I don't know if this is possible/recommended for LD-R. If I run npm install webpack --save-dev (without having a webpack installed globally) it tells me that webpack is already up to date:

C:\Users\USER-NAME\Documents\LD-R\ld-r12>npm install --save-dev webpack
npm notice created a lockfile as package-lock.json. You should commit this file.
up to date in 13.041s

Any ideas on how to proceed regarding a local webpack installation? If it mathers, I use a node version manager called nvm-windows v1.1.6

[ali1k]

@mathib that's weird! maybe it is a problem with the path of Webpack in the Windows.
The best way to resolve the issue is to have a call where we can try different options.

[mathib]

For anyone interested in my issue: it was related to a NODE_ENV system variable set to 'production'. This made it impossible to install with npm install the devDependencies such as Webpack and others. I've used this source.

I've changed the NODE_ENV to 'development'. To be certain, I've also checked the npm config get production and made sure it was set to false (npm config set -g production false)

@ali1k Thanks for the assistence! Issue can be closed :)