Coder Social home page Coder Social logo

Typo in Algorithm 21.9 about decisionmaking HOT 7 CLOSED

Tom-CCS avatar Tom-CCS commented on June 29, 2024
Typo in Algorithm 21.9

from decisionmaking.

Comments (7)

mykelk avatar mykelk commented on June 29, 2024

In case this link is not accessible to @tawheeler

I am failing to understand the weighting steps in Algorithm 21.9. The relevant steps are

# say w = [1,2,3]
w /= sum(w)
w = [1 - wi for wi in w]
# w would be [0.83, 0.67, 0.5] here

I'm not sure if I understood this correctly, but I believe this would result in a weight vector that sums to $|S| - 1$ instead of $1$, which doesn't make sense. May I ask if there might be a typo here?

from decisionmaking.

tawheeler avatar tawheeler commented on June 29, 2024

I think that is indeed a mistake. It should be:

dists = [<L1 distances>]
w = normalize([1/(d+eps) for d in dists], 1)

We can confirm with Kyle if we want to, but this is how kernel smoothing does it (section 8.3).

I'll commit a fix. Thank you!

from decisionmaking.

tawheeler avatar tawheeler commented on June 29, 2024

@Tom-CCC, we typically add contributors to our acknowledgements section. If you would like to be added, could you please share your first and last name?

from decisionmaking.

mykelk avatar mykelk commented on June 29, 2024

I'll double check with Kyle real quick.

from decisionmaking.

Tom-CCS avatar Tom-CCS commented on June 29, 2024

Sure, My name is Shengtong Zhang.

from decisionmaking.

mykelk avatar mykelk commented on June 29, 2024

Great! We're still digging into this. The reference implementation is here:
https://github.com/trey0/zmdp/blob/master/src/pomdpBounds/SawtoothUpperBound.cc#L46

from decisionmaking.

mykelk avatar mykelk commented on June 29, 2024

We have updated the implementation in Alg. 21.9 and reposted the PDF and acknowledged you. We also streamlined the text in Sec. 21.6. Thank you for bringing this to our attention!

from decisionmaking.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.