Comments (10)
If that's the cause, I think these three lines should change:
- https://github.com/algolia/shipjs/blob/62267a1da0b7e3fd946f45a439df5fc58a85c4c1/packages/shipjs-lib/src/lib/git/getRepoInfo.js#L7:L7
- https://github.com/algolia/shipjs/blob/62267a1da0b7e3fd946f45a439df5fc58a85c4c1/packages/shipjs-lib/src/lib/git/getRepoURLWithToken.js#L7:L7
- https://github.com/algolia/shipjs/blob/62267a1da0b7e3fd946f45a439df5fc58a85c4c1/packages/shipjs-lib/src/lib/git/getRepoURLWithTokenMasked.js#L7:L7
There can be a config for that like
// ship.config.js
module.exports = {
githubHost: 'my-own-gh-enterprise.com'
};
What do you think? Would you be interested in contributing?
from shipjs.
Hello @swaprenge
Thanks for trying out Ship.js. Do you have GITHUB_TOKEN
environment variable in .env
file? I do not have experience with GH Enterprise account. It'd be much helpful if you could provide screenshots or error messages if any.
Or, you could have a cron job in the GitHub Action to run yarn run release
periodically (like every week). Then I guess GH Action will take care of the authentication process as well. But you may want to run yarn run release
manually. So I'd appreciate if you could provide more information. Thanks!
from shipjs.
Hi @eunjae-lee Thanks for your reply. I have setup GITHUB_TOKEN
in .env
file (Checking the Github token step is successful) and I am attaching the screenshot of the error I am getting.
Let me know if you need any other details.
Thanks.
from shipjs.
From the above image, You will get that, I have been asked to do the SignIn using the Github, but it should ask for Github enterprise SignIn, as my repository is in the Enterprise account. I am not sure how can i SignIn using the Enterprise account.
from shipjs.
Hi @swaprenge, first of all, I have no experience with GH enterprise, so I've never seen that sign-in page. So I may be wrong on what I'm talking about.
On your first screenshot I see
fatal: repository 'https://github.com/FactSet/pw-systemtools-config-dashboard/' not found
I assume.. the domain is not github.com but something of your company's, right?
Do you think if it tries to push to the correct origin, you'll see the correct sign-in page?
from shipjs.
If that's the cause, I think these three lines should change:
- https://github.com/algolia/shipjs/blob/62267a1da0b7e3fd946f45a439df5fc58a85c4c1/packages/shipjs-lib/src/lib/git/getRepoInfo.js#L7:L7
- https://github.com/algolia/shipjs/blob/62267a1da0b7e3fd946f45a439df5fc58a85c4c1/packages/shipjs-lib/src/lib/git/getRepoURLWithToken.js#L7:L7
- https://github.com/algolia/shipjs/blob/62267a1da0b7e3fd946f45a439df5fc58a85c4c1/packages/shipjs-lib/src/lib/git/getRepoURLWithTokenMasked.js#L7:L7
There can be a config for that like
// ship.config.js module.exports = { githubHost: 'my-own-gh-enterprise.com' };
What do you think? Would you be interested in contributing?
@eunjae-lee I think these suggested changes will be required to support the enterprise host.
And yeah, I would love to contribute. I Will raise a PR by making the changes.
Thanks.
from shipjs.
Hi @swaprenge, first of all, I have no experience with GH enterprise, so I've never seen that sign-in page. So I may be wrong on what I'm talking about.
On your first screenshot I see
fatal: repository 'https://github.com/FactSet/pw-systemtools-config-dashboard/' not found
I assume.. the domain is not github.com but something of your company's, right? Do you think if it tries to push to the correct origin, you'll see the correct sign-in page?
Yeah, If we push to the correct origin (i,e GitHub enterprise in my case) then we might see the correct sign-in page.
from shipjs.
Thanks for the contribution @swaprenge :) I'll wait for your PR then.
from shipjs.
@eunjae-lee apologies for the late, I was trying to make the above changes, but not sure about how to access githubHost
defined in ship.config.js
in files to replace hard-coded github.com
Can you please help me to do these changes?
Thanks.
from shipjs.
I think I got it, We need to use the loadConfig
function to get config values, Will try to use it and will update,
@eunjae-lee I am trying to push the PR, but getting permission denied.
PS: I ran yarn contributors:add
command as well.
from shipjs.
Related Issues (20)
- update content of README.md
- setup: help with protected branch HOT 1
- Not a bug, just need help getting started... HOT 6
- Updating PR message
- Updating guide on `release:prepare` and `release:trigger` HOT 5
- What if we get rid of the concept of "mergeStrategy" ? HOT 2
- Improve GitHub Actions template HOT 9
- Generate .env when run shipjs setup HOT 5
- failure in setting npm config in shipjs trigger HOT 7
- Can't trigger release if there's only one commit HOT 3
- pullRequestReviewers octokit deprecation error HOT 2
- Getting the branch in prepare for multiple releases HOT 1
- Dependency Dashboard
- [Vulnerability] An issue with shelljs in `shipjs-lib` internal package HOT 3
- Setup wizard showing incomplete branch names HOT 5
- "Git tag doesn't exist" in GitHub Actions HOT 2
- fix(deps): issue with one of the transitive dependency causing dependabot alert(s) HOT 1
- make `nextVersion` work with multiple versions
- trigger workflow fails to create a tag HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shipjs.