Comments (6)
Attached an XML file of the example program mentioned above.
Original comment by [email protected]
on 10 Jun 2012 at 4:06
- Added labels: ****
- Removed labels: ****
Attachments:
from blockly.
Added patch to fix issue.
Note that this creates a global statement for any variable that is a) assigned,
b) used in a 'change _ by _' statement, or c) used as the control variable of a
for or for-each loop.
Original comment by [email protected]
on 10 Jun 2012 at 5:49
- Added labels: ****
- Removed labels: ****
Attachments:
from blockly.
Great bug, greater patch! Modified it slightly so potential new blocks will be
covered. Your patch is superior in that it only makes global any assigned
variables (in setters), whereas ours catches all variables, even just getters.
For the educational environment, we feel that consistency is better.
Original comment by [email protected]
on 10 Jun 2012 at 7:23
- Changed state: Fixed
- Added labels: ****
- Removed labels: ****
from blockly.
Cool, thanks for accepting. One thing is I'm not sure what you mean by
"consistency is better."
Are you talking about consistency in the behaviour of the Python program when
it runs? Or that it's simply better to list all variables in 'globals' for
clarity (regardless of whether it is redundant)?
Because if you mean the latter, I take your point. But if you mean the former,
then please note that my patch is equivalent in terms of runtime behaviour: if
a variable is not assigned in a function, then Python will implicitly treat it
as global, so there is no need to explicitly label it as 'global'. So using my
example above, your patch will mean that 'global x' appears in the printx
function, even though it is unnecessary to do so.
But I do take your point: it is much less likely to break in the future if you
simply declare all variables as global instead of trying to be clever as I was.
Original comment by [email protected]
on 10 Jun 2012 at 7:40
- Added labels: ****
- Removed labels: ****
from blockly.
We were thinking of consistency for users. Imagine a user sees this code:
def foo():
global x
x += 1
print y
Then they add "y += 1" to the generated Python function and wonder why it just
blew up. That's weird even for a seasoned programmer who's unfamiliar with
Python's whacky/awesome/fearsome scope system. Just pretending that all
variables need to be listed is simpler to understand.
Original comment by [email protected]
on 10 Jun 2012 at 7:47
- Added labels: ****
- Removed labels: ****
from blockly.
Right, got you. That makes sense.
Original comment by [email protected]
on 10 Jun 2012 at 8:55
- Added labels: ****
- Removed labels: ****
from blockly.
Related Issues (20)
- JSON Export Import HOT 1
- Need plain "Return" w/o IF HOT 1
- When using blockly maze and puzzle etc the drop down arrows on the blocks don't operate on an iPad. HOT 1
- Number of app's lang-manu HOT 2
- turtle trail does not show on Android Nexus 10
- Blockly.Xml.workspaceToDom doesn´t work on Safari HOT 2
- context menu on tablets HOT 1
- Non Printing Text Characters
- [deleted issue]
- [deleted issue]
- Color dropdowns not listening for touch events HOT 1
- Trashcan Lid animation uses CPU when idle HOT 1
- Uncollapsing duplicated block "Connection already in database" error HOT 2
- Code blocks can become misaligned when moving a set of blocks with a "break out of loop" attached to it out of a loop
- Mouse wheel scrolling fails to scroll blockly scroll bars up or down HOT 1
- Blocky GUI is pushed from view when a long text string is entered into a block
- If block breaks when click on the star. HOT 1
- Blockly games not running correctly on chrome! HOT 4
- Headless blockly doesn't work for function/procedure calls with parameters HOT 1
- How to create types to restrict connections between few custom blocks?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blockly.