Coder Social home page Coder Social logo

Comments (4)

alexklibisz avatar alexklibisz commented on May 22, 2024

You're catching a lot of things I hadn't thought of. Very helpful 👍
It should probably just return no documents. I believe there's a way to compose the custom query with a query that checks for the presence of that field. Will look into it.

from elastiknn.

alexklibisz avatar alexklibisz commented on May 22, 2024

I was trying to reproduce this one in a test, and accidentally reproduced #180 😆
Hopefully they're the same underlying issue.

from elastiknn.

alexklibisz avatar alexklibisz commented on May 22, 2024

@ejackson-eb So I ended up adding a test in #184 that does the following:

  • Create an index.
  • Put a mapping that includes a simple ID keyword field and a vector field with the same AngularLsh mapping you showed above, albeit lower dimension vectors (128).
  • Index 20k docs. The even-numbered docs include a valid vector. The odd numbered docs include nothing for the vector field.
  • Run a count query to count number of docs with ID field .. should be 20k
  • Run a count query to count number of docs with vector field .. should be 10k
  • Run an exact query using the 0th vector as the query vector .. should return the 0th vector as top hit.
  • Run an approx query with the same query vector .. should return same top hit.

I found that after increasing from 10k to 20k I started seeing the issue you mentioned over in #180.
I never actually saw a null pointer exception.

So I'd suggest trying out the fix that I linked here: #180 (comment)
And then if you still get null pointer exceptions, it would be super helpful if you can provide a python or bash script that reproduces the issue. It's fine if you just email it to me, and also totally fine if the vectors are just random numbers.

from elastiknn.

alexklibisz avatar alexklibisz commented on May 22, 2024

This seems to be resolved based on some email discussion.

from elastiknn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.