Comments (4)
Interesting. It's certainly not necessary, but I do like having some sort of sanity check that says "I'm connected to something that looks like an Asterisk server".
Does this emulator emit one line followed by \r\n?
from amiclient.
Yes. Without the part that throws the exception your library works flawlessly. The library still reads the first line, but instead just ignores it.
I think it's responsibility of a developer, not library, to connect to the correct server. If the library connects to the wrong server, it won't work anyway. If it connects to the server that tries to mimic AMI for bad purposes, it isn't hard for the server to send correct handshake message, so there isn't much point as far as I know.
from amiclient.
Yeah this isn't a problem. I need to check that the server emits something so that this check keeps working, but I don't think it's necessary to check for the correct verbiage. I'll just check that I successfully read a non-empty line. I'll cut a new release tonight or tomorrow.
from amiclient.
Thank you very much.
from amiclient.
Related Issues (13)
- Hanging during login on asp.net core running in linux docker container HOT 6
- Partial socket reads could cause the worker thread to block indefinitely
- Can i use this library for video calling on asterisk? HOT 1
- Sometimes events have the field "Response" (For example BridgeAction) HOT 1
- System.TypeLoadException: 'Could not load type 'Ami.AmiClient' from assembly 'AMIClient, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.'
- how to get hang up event
- DataReceived not firing HOT 1
- TCP zero window on Hi-load HOT 1
- Not working AmiClient.Subscribe
- The response is truncated, when the message exceeds the byte length(4096)
- Nuget package hangs on Login HOT 10
- Ergonomics of handling server failure HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amiclient.